From: Olaf Hering <olh@suse.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
"David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: comment about struct tcp_tw_bucket in struct sock
Date: Tue, 13 May 2003 23:05:41 +0200 [thread overview]
Message-ID: <20030513210541.GA4415@suse.de> (raw)
Hi,
we just hit this one. struct tcp_tw_bucket and stuct sock must match.
Please apply.
--- linux-2.4/include/net/sock.h 2003-04-24 17:11:20.000000000 +0200
+++ linux-2.4.21-rc2/include/net/sock.h 2003-05-13 23:00:32.000000000 +0200
@@ -498,6 +498,10 @@ do { spin_lock_init(&((__sk)->lock.slock
} while(0)
struct sock {
+ /* These _must_ match the beginning of struct tcp_tw_bucket precisely.
+ * XXX Yes I know this is gross, but I'd have to edit every single
+ * XXX networking file if I created a "struct sock_header". -DaveM
+ */
/* Socket demultiplex comparisons on incoming packets. */
__u32 daddr; /* Foreign IPv4 addr */
__u32 rcv_saddr; /* Bound local IPv4 addr */
--
USB is for mice, FireWire is for men!
next reply other threads:[~2003-05-13 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 21:05 Olaf Hering [this message]
2003-05-13 23:31 ` comment about struct tcp_tw_bucket in struct sock David S. Miller
2003-05-14 2:44 ` Arnaldo Carvalho de Melo
2003-05-14 8:00 ` Olaf Hering
2003-05-14 19:17 ` David S. Miller
2003-05-14 19:23 ` Andi Kleen
2003-05-14 19:34 ` David S. Miller
2003-05-14 19:57 ` Andi Kleen
2003-05-14 20:02 ` David S. Miller
2003-05-14 8:32 ` Andi Kleen
2003-05-14 19:18 ` David S. Miller
2003-05-14 19:21 ` Andi Kleen
2003-05-22 0:52 ` Arnaldo Carvalho de Melo
2003-05-22 8:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513210541.GA4415@suse.de \
--to=olh@suse.de \
--cc=davem@redhat.com \
--cc=marcelo@conectiva.com.br \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.