From: William Lee Irwin III <wli@holomorphy.com>
To: gibbs@scsiguy.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: ahc_linux_map_seg() compile/style/data corruption fixes
Date: Tue, 13 May 2003 22:46:25 -0700 [thread overview]
Message-ID: <20030514054625.GF2444@holomorphy.com> (raw)
In-Reply-To: <20030514053747.GE2444@holomorphy.com>
On Tue, May 13, 2003 at 10:37:47PM -0700, William Lee Irwin III wrote:
> Hmm, 2.5.x is supposed to guarantee most (if not all) of the
> preconditions the code here is trying to (re)establish. Probably the
> only use of not ripping out the 4GB spanning code and segment count
> checks is to keep driver versions synched. As it stands, this doesn't
> compile and if ever invoked the code not needed for 2.5 will not behave
> as expected (though thankfully a nop). Maybe a (shudder) #ifdef to rip
> out the overhead for 2.5 should be added esp. as post gcc-3.0 probably
> can't compile earlier kernels anyway.
Clarification: the code before my patch doesn't compile with gcc-3.3;
the code after it does. Mutatis mutandis with respect to the unexpected
behavior.
-- wli
next prev parent reply other threads:[~2003-05-14 5:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 4:49 ahc_linux_map_seg() compile/style/data corruption fixes William Lee Irwin III
2003-05-14 5:37 ` William Lee Irwin III
2003-05-14 5:46 ` William Lee Irwin III [this message]
2003-05-14 6:18 ` Justin T. Gibbs
2003-05-14 6:21 ` William Lee Irwin III
2003-05-14 6:26 ` Justin T. Gibbs
2003-05-14 6:28 ` William Lee Irwin III
2003-05-15 16:36 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030514054625.GF2444@holomorphy.com \
--to=wli@holomorphy.com \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.