From: Vojtech Pavlik <vojtech@suse.cz>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Lionel.Bouton@inet6.fr, alan@lxorguk.ukuu.org.uk,
marcelo@conectiva.com.br, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch] Support for SiS 961/961B/962/963/630S/630ET/633/733 IDE
Date: Sat, 17 May 2003 10:16:03 +0200 [thread overview]
Message-ID: <20030517101603.B25569@ucw.cz> (raw)
In-Reply-To: <Pine.SOL.4.30.0305161903590.16125-100000@mion.elka.pw.edu.pl>; from B.Zolnierkiewicz@elka.pw.edu.pl on Fri, May 16, 2003 at 07:14:36PM +0200
On Fri, May 16, 2003 at 07:14:36PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Good job, but...
>
> On Fri, 16 May 2003, Vojtech Pavlik wrote:
> > And while doing the changes I did also some cleanups, mainly removing a
> > bunch of debug code that doesn't seem very useful when lspci does the
> > same job. And removing the config_drive_xfer_rate in favor of functions
> > from ide-timing.h.
>
> Debug code in fe. SiS IDE driver does the same as lspci given you get to
> the point you can run lspci. Dumping of PCI conf regs should be moved to
> generic IDE PCI code as it might be useful for other IDE PCI drivers.
Yes, that would be useful.
> Removing config_drive_xfer_rate() is bad,
> fe. you don't check for bad drives now.
True. That needs to be added to ide_find_best_mode in ide-timing.h.
Which needs to be converted to ide-timing.c.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
prev parent reply other threads:[~2003-05-17 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-16 12:30 [patch] Support for SiS 961/961B/962/963/630S/630ET/633/733 IDE Vojtech Pavlik
2003-05-16 16:07 ` David van Hoose
2003-05-16 16:25 ` Vojtech Pavlik
2003-05-16 17:14 ` Bartlomiej Zolnierkiewicz
2003-05-17 8:16 ` Vojtech Pavlik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030517101603.B25569@ucw.cz \
--to=vojtech@suse.cz \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=Lionel.Bouton@inet6.fr \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.