All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] laptop mode, #2
Date: Sun, 18 May 2003 08:11:21 +0200	[thread overview]
Message-ID: <20030518061121.GD812@suse.de> (raw)
In-Reply-To: <20030517164733.B10850@schatzie.adilger.int>

On Sat, May 17 2003, Andreas Dilger wrote:
> On May 16, 2003  13:33 +0200, Jens Axboe wrote:
> > +	if (block_dump)
> > +		printk("%s: %s block %lu/%u on %s\n", current->comm, rw == WRITE ? "WRITE" : "READ", bh->b_rsector, count, kdevname(bh->b_rdev));
> 
> This should be changed to KERN_DEBUG or similar, since if you are logging
> kernel messages to disk you get stuck in an infinite loop with block_dump:
> 
> kjournald: WRITE block 67416/8 on 03:05
> kjournald: WRITE block 67424/8 on 03:05
> kjournald: WRITE block 67432/8 on 03:05
> kjournald: WRITE block 548144/8 on 03:05
> kjournald: WRITE block 67440/8 on 03:05
> kjournald: WRITE block 67448/8 on 03:05
> kjournald: WRITE block 67456/8 on 03:05

Or just stop syslog, I did mention you had to be careful with it.

-- 
Jens Axboe


      reply	other threads:[~2003-05-18  5:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-16 11:33 [PATCH] laptop mode, #2 Jens Axboe
2003-05-16 19:55 ` Pavel Machek
2003-05-17  8:16   ` Jens Axboe
2003-05-17 22:47 ` Andreas Dilger
2003-05-18  6:11   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030518061121.GD812@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.