From: Christoph Hellwig <hch@lst.de>
To: Jaroslav Kysela <perex@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove 2.2 compat cruft from sound/
Date: Mon, 19 May 2003 11:42:17 +0200 [thread overview]
Message-ID: <20030519114217.A4325@lst.de> (raw)
In-Reply-To: <20030519113856.A4282@lst.de>; from hch@lst.de on Mon, May 19, 2003 at 11:38:56AM +0200
On Mon, May 19, 2003 at 11:38:56AM +0200, Christoph Hellwig wrote:
> On Mon, May 19, 2003 at 10:44:46AM +0200, Jaroslav Kysela wrote:
> > We still support the 2.2 kernel. We are trying to separate this
> > "compatibility" code to another location, but in some cases, it is
> > difficult. Please, make changes only for /sound/oss tree. Thank you.
>
> I sterongly disagree. As part of having your code in mainline you
> have to keep it readable. Neither the compat mess nor the typedef
> abuse help on this.
>
And it's not like the 2.2 code was actually working, e.g. the dropping
of i_sem in ->write makes you allow multiple simultanous writes, your
module refcounting on 2.2 is completly b0rked due to the lack of ->owner
and many functions have change parameters..
next prev parent reply other threads:[~2003-05-19 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-18 16:15 [PATCH] remove 2.2 compat cruft from sound/ Christoph Hellwig
2003-05-19 8:44 ` Jaroslav Kysela
2003-05-19 9:38 ` Christoph Hellwig
2003-05-19 9:42 ` Christoph Hellwig [this message]
2003-05-19 10:15 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030519114217.A4325@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.