All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dentry/inode accounting for vm_enough_mem()
Date: Tue, 20 May 2003 02:27:01 -0700	[thread overview]
Message-ID: <20030520022701.406a0d4e.akpm@digeo.com> (raw)
In-Reply-To: <1053391863.12309.2.camel@nighthawk>

Dave Hansen <haveblue@us.ibm.com> wrote:
>
>   struct dentry_stat_t {
>   	int nr_dentry;
>   	int nr_unused;
>  +	atomic_t nr_alloced;
>   	int age_limit;          /* age in seconds */
>   	int want_pages;         /* pages requested by system */
>   	int dummy[2];

We're not at liberty to do this because /proc/sys/fs/dentry-state and
inode-state are implemented assuming that these structs are an array of
integers.  It'll screw up if the architecture's "int" and "atomic_t"
representations are different.

Probably you can just make this an integer and add a spinlock for it, or
not place it in dentry_stat.

Seems otherwise OK though.  Thanks.

  reply	other threads:[~2003-05-20  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-20  0:51 [PATCH] dentry/inode accounting for vm_enough_mem() Dave Hansen
2003-05-20  9:27 ` Andrew Morton [this message]
2003-05-20 10:08 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030520022701.406a0d4e.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.