From: Pete Zaitcev <zaitcev@redhat.com>
To: linux390@de.ibm.com
Cc: Pete Zaitcev <zaitcev@redhat.com>,
James Antill <jantill@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Patch for strncmp use in s390 in 2.5
Date: Wed, 28 May 2003 16:20:19 -0400 [thread overview]
Message-ID: <20030528162019.A3492@devserv.devel.redhat.com> (raw)
Martin & others:
I didn't see this posted before. Sorry if I missed it.
It's a harmless buglet which causes false positives with correctness
checking tools, and so annoys me.
Cheers,
-- Pete
--- linux-2.5.69-bk12/arch/s390/kernel/setup.c 2003-05-11 12:56:15.000000000 -0700
+++ linux-2.5.69-bk12-s390/arch/s390/kernel/setup.c 2003-05-28 13:01:54.000000000 -0700
@@ -165,15 +165,15 @@
static int __init conmode_setup(char *str)
{
#if defined(CONFIG_SCLP_CONSOLE)
- if (strncmp(str, "hwc", 4) == 0 || strncmp(str, "sclp", 5) == 0)
+ if (strncmp(str, "hwc", 3) == 0 || strncmp(str, "sclp", 4) == 0)
SET_CONSOLE_SCLP;
#endif
#if defined(CONFIG_TN3215_CONSOLE)
- if (strncmp(str, "3215", 5) == 0)
+ if (strncmp(str, "3215", 4) == 0)
SET_CONSOLE_3215;
#endif
#if defined(CONFIG_TN3270_CONSOLE)
- if (strncmp(str, "3270", 5) == 0)
+ if (strncmp(str, "3270", 4) == 0)
SET_CONSOLE_3270;
#endif
return 1;
next reply other threads:[~2003-05-28 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-28 20:20 Pete Zaitcev [this message]
2003-05-28 20:34 ` Patch for strncmp use in s390 in 2.5 Richard B. Johnson
2003-05-28 20:51 ` Patch for strncmp use in s390 (sclp) Pete Zaitcev
2003-05-28 21:55 ` Patch for strncmp use in s390 in 2.5 Richard Braakman
[not found] ` <mailman.1054159021.10246.linux-kernel2news@redhat.com>
2003-05-28 23:45 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030528162019.A3492@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=jantill@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.