All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mark Haverkamp <markh@osdl.org>
Cc: Pat Mochel <mochel@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pci bridge class code
Date: Fri, 30 May 2003 16:13:48 -0700	[thread overview]
Message-ID: <20030530231348.GA22049@kroah.com> (raw)
In-Reply-To: <1054239461.28608.74.camel@markh1.pdx.osdl.net>

On Thu, May 29, 2003 at 01:17:42PM -0700, Mark Haverkamp wrote:
> This adds pci-pci bridge driver model class code.  Entries appear in 
> /sys/class/pci_bridge.

Nice, but I don't see the need for the extra class information, as it
doesn't really give us anything new, right?  So without the class stuff
might be nice.

> +MODULE_AUTHOR("Mark Haverkamp");
> +MODULE_DESCRIPTION("PCI bridge driver");
> +MODULE_LICENSE("GPL");

This isn't needed, as you can't build your code as a module with your
patch.

thanks,

greg k-h

  parent reply	other threads:[~2003-05-30 22:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-29 20:17 [PATCH] pci bridge class code Mark Haverkamp
2003-05-29 20:40 ` Russell King
2003-05-30  9:44   ` Alan Cox
2003-06-02 11:56     ` Benjamin Herrenschmidt
2003-06-02 12:32       ` Russell King
2003-06-02 12:39         ` Benjamin Herrenschmidt
2003-06-02 14:25           ` Mark Haverkamp
2003-05-30 23:13 ` Greg KH [this message]
2003-06-02 20:30   ` Mark Haverkamp
2003-06-02 20:35     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030530231348.GA22049@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@osdl.org \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.