From: Stig Brautaset <stig@brautaset.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.70: scripts/Makefile.build fix
Date: Sun, 1 Jun 2003 23:28:40 +0100 [thread overview]
Message-ID: <20030601222840.GA13170@brautaset.org> (raw)
In-Reply-To: <fa.hcaig7b.n72lar@ifi.uio.no>
On Jun 01 2003, Sam wrote:
> On Sun, Jun 01, 2003 at 07:43:35PM +0100, Stig Brautaset wrote:
> > Hi,
> >
> > This patch seems to fix `make V=0' for me.
>
> Thanks for the patch.
> I do not see the broken behaviour here. Can you provide me with information
> about your system:
> Make version, shell, architecture, distribution.
I'm on a debian testing/unstable hybrid, and `uname -a' says:
Linux arwen 2.4.20 #1 Sun Jan 26 13:54:18 GMT 2003 i686 GNU/Linux
zsh/testing uptodate 4.0.6-30 # interactive shell
dash/testing uptodate 0.4.17 # /bin/sh
make/testing uptodate 3.80-1
> I got one report in private mail about make V=0 was broken, and would
> like to find out what is causing the problem.
I believe the problem occurs because (without my patch) the last three
lines of the following define is invoked in its own subshell, and
echoing the commands for that second subshell is not omitted.
define rule_vcc_o_c
$(if $($(quiet)cmd_checksrc),echo ' $($(quiet)cmd_checksrc)';) \
$(cmd_checksrc) \
$(if $($(quiet)cmd_vcc_o_c),echo ' $($(quiet)cmd_vcc_o_c)';) \
$(cmd_vcc_o_c); \
\
if ! $(OBJDUMP) -h $(@D)/.tmp_$(@F) | grep -q __ksymtab; then \
mv $(@D)/.tmp_$(@F) $@; \
else \
$(CPP) -D__GENKSYMS__ $(c_flags) $< \
| $(GENKSYMS) \
> $(@D)/.tmp_$(@F:.o=.ver); \
\
$(LD) $(LDFLAGS) -r -o $@ $(@D)/.tmp_$(@F) \
-T $(@D)/.tmp_$(@F:.o=.ver); \
rm -f $(@D)/.tmp_$(@F) $(@D)/.tmp_$(@F:.o=.ver); \
fi; \
scripts/fixdep $(depfile) $@ '$(cmd_vcc_o_c)' > $(@D)/.$(@F).tmp; \
rm -f $(depfile); \
mv -f $(@D)/.$(@F).tmp $(@D)/.$(@F).cmd
endef
Stig
--
brautaset.org
next parent reply other threads:[~2003-06-01 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.eruk8hn.73g20l@ifi.uio.no>
[not found] ` <fa.hcaig7b.n72lar@ifi.uio.no>
2003-06-01 22:28 ` Stig Brautaset [this message]
2003-06-04 19:17 ` 2.5.70: scripts/Makefile.build fix Sam Ravnborg
2003-06-01 18:43 Stig Brautaset
2003-06-01 20:44 ` Sam Ravnborg
2003-06-01 21:40 ` Kenneth Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030601222840.GA13170@brautaset.org \
--to=stig@brautaset.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.