From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@digeo.com>
Cc: adam@yggdrasil.com, linux-kernel@vger.kernel.org
Subject: Re: Counter-kludge for 2.5.x hanging when writing to block device
Date: Tue, 3 Jun 2003 12:02:55 +0200 [thread overview]
Message-ID: <20030603100255.GJ482@suse.de> (raw)
In-Reply-To: <20030603030023.69d39d6e.akpm@digeo.com>
On Tue, Jun 03 2003, Andrew Morton wrote:
> > Does something like this work? Andrew, what's the point of doing the
> > wait if the queue isn't congested?!
>
> We need to wait until the amount of dirty memory in the machine is below
> the designated limits. This is unrelated to queue congestion. The way the
> logic is now we can have 256 megs worth of requests queues on a 32M machine
> and everything throttles and clamps as intended.
>
>
> There are several things wrong with blk_congestion_wait(), including:
>
> a) it should be called throttle_on_io()
Well...
> b) it should check that there are still requests in flight after parking
> itself on the waitqueue rather than relying on the timeout.
This is important, would be much nicer to pass in the backing dev. This
is a big problem, imho. It's broken right now.
> As for Adam's hang: dunno. I and many others have run mkfs and dd an
> unbelievable number of times. He needs to debug it more.
Agree
--
Jens Axboe
next prev parent reply other threads:[~2003-06-03 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 8:48 Counter-kludge for 2.5.x hanging when writing to block device Adam J. Richter
2003-06-03 9:10 ` Jens Axboe
2003-06-03 10:00 ` Andrew Morton
2003-06-03 10:02 ` Jens Axboe [this message]
2003-06-03 10:20 ` Andrew Morton
2003-06-03 14:42 ` Jens Axboe
2003-06-03 10:21 ` Michael Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030603100255.GJ482@suse.de \
--to=axboe@suse.de \
--cc=adam@yggdrasil.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.