From: Christoph Hellwig <hch@lst.de>
To: dledford@redhat.com
Cc: linux-scsi@vger.kernel.org
Subject: What's the state of sdev->tagged_queue
Date: Fri, 6 Jun 2003 09:48:13 +0200 [thread overview]
Message-ID: <20030606074813.GA18748@lst.de> (raw)
Hi Doug,
scsi_ioctl.c has the following comment from you:
* The next two ioctls either need to go or need to be changed to
* pass tagged queueing changes through the low level drivers.
* Simply enabling or disabling tagged queueing without the knowledge
* of the low level driver is a *BAD* thing.
and scsi.h has this:
unsigned tagged_queue:1;/* This is going away!!!! Look at simple_tags
instead!!! Please fix your driver now!! */
but several drivers still look at it although it's never touched
outside scsi_ioctl.c and the individual drivers. Most drivers uses also
look pretty bogus. Can we just the ioctls and the field?
53c700.c: if(SCp->device->tagged_supported && !SCp->device->tagged_queue
AM53C974.c: if (!hostdata->connected->device->tagged_queue)
AM53C974.c: cmd->device->tagged_queue = 0;
AM53C974.c: if (cmd->device->tagged_queue && (tag != TAG_NONE)) {
NCR5380.c: cmd->device->tagged_queue = 0;
arm/acornscsi.c: if (SCpnt->device->tagged_queue) {
arm/acornscsi.c: host->SCpnt->device->tagged_queue = 0;
arm/acornscsi.c: scd->tagged_queue ? "en" : "dis",
arm/fas216.c: if (SCpnt->device->tagged_queue && SCpnt->cmnd[0] != REQUEST_SENSE &&
arm/fas216.c: scd->tagged_queue ? "en" : "dis",
ncr53c8xx.c: if (lp && !lp->numtags && cmd->device && cmd->device->tagged_queue) {
qla1280.c: if (cmd->device->tagged_queue)
qla1280.c: if (cmd->device->tagged_queue)
scsi.h: unsigned tagged_queue:1;/* This is going away!!!! Look at simple_tags
scsi_ioctl.c: sdev->tagged_queue = 1;
scsi_ioctl.c: sdev->tagged_queue = 0;
sym53c8xx.c: if (lp && !lp->numtags && cmd->device && cmd->device->tagged_queue) {
next reply other threads:[~2003-06-06 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-06 7:48 Christoph Hellwig [this message]
2003-06-06 14:04 ` What's the state of sdev->tagged_queue Doug Ledford
2003-06-06 14:19 ` Christoph Hellwig
2003-06-06 14:28 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030606074813.GA18748@lst.de \
--to=hch@lst.de \
--cc=dledford@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.