Re: [PATCH] Making keyboard/mouse drivers dependent on CONFIG_EMBEDDED

[Pavel Machek <pavel@suse.cz>]

Hi!


> > I finally got sick of seeing bug reports from people who did not enable
> > CONFIG_VT or forgot to enable the obscure options for the keyboard
> > driver. This is especially a big problem for people who do make oldconfig
> > with a 2.4 configuration, but seems to happen in general often.
> > I also included the PS/2 mouse driver. It is small enough and a useful
> > fallback on any PC.
> > 
> > This patch wraps all this for i386/amd64 in CONFIG_EMBEDDED. If 
> > CONFIG_EMBEDDED is not defined they are not visible and always enabled.
> 
> This sounds like a bad idea.  many modern PCs only have usb keyboard/mouse
> these days.  Having them in defconfig is fine but we shouldn't obsfucate
> the kernel config due to user stupidity.

Its more like "make oldconfig" limitation, IIRC. If you have some old
config, it ignores defconfig and suggests you N for new options. And
yes people were hitting that.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]