Re: [PATCH 2/7] dm: signed/unsigned audit

[Kevin Corry <kevcorry@us.ibm.com>]

On Monday 09 June 2003 09:35, Joe Thornber wrote:
> signed/unsigned audit.

> --- diff/drivers/md/dm.c	2003-05-21 11:50:15.000000000 +0100
> +++ source/drivers/md/dm.c	2003-06-09 15:05:02.000000000 +0100
> @@ -546,21 +546,22 @@
>
>  	spin_lock(&_minor_lock);
>  	if (!test_and_set_bit(minor, _minor_bits))
> -		r = minor;
> +		r = 0;
>  	spin_unlock(&_minor_lock);
>
>  	return r;
>  }
>
> -static int next_free_minor(void)
> +static int next_free_minor(unsigned int *minor)
>  {
> -	int minor, r = -EBUSY;
> +	unsigned int m, r = -EBUSY;

Looks like "r" should still be signed.

>  	spin_lock(&_minor_lock);
> -	minor = find_first_zero_bit(_minor_bits, MAX_DEVICES);
> -	if (minor != MAX_DEVICES) {
> -		set_bit(minor, _minor_bits);
> -		r = minor;
> +	m = find_first_zero_bit(_minor_bits, MAX_DEVICES);
> +	if (m != MAX_DEVICES) {
> +		set_bit(m, _minor_bits);
> +		*minor = m;
> +		r = 0;
>  	}
>  	spin_unlock(&_minor_lock);
>

-- 
Kevin Corry
kevcorry@us.ibm.com
http://evms.sourceforge.net/