From: Daniel Phillips <dphillips@sistina.com>
To: dm-devel@sistina.com, Greg KH <greg@kroah.com>,
Joe Thornber <thornber@sistina.com>
Cc: dm-devel@sistina.com, Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [dm-devel] Re: [RFC] device-mapper ioctl interface
Date: Mon, 9 Jun 2003 22:03:50 +0200 [thread overview]
Message-ID: <200306092203.50024.dphillips@sistina.com> (raw)
In-Reply-To: <20030606171700.GC12231@kroah.com>
On Friday 06 June 2003 19:17, Greg KH wrote:
> On Thu, Jun 05, 2003 at 10:39:43AM +0100, Joe Thornber wrote:
> > Here's the header file for the the proposed new ioctl interface for
> > dm. We've tried to change as little as possible to minimise code
> > changes in LVM2 and EVMS.
>
> Minor comment:
> - please do not use uint_32t types in kernel header files. Use
> the proper __u32 type which is guarenteed to be the proper
> size across the user/kernel boundry.
We even have a flavor without the __'s:
http://lxr.linux.no/source/include/asm-i386/types.h?v=2.5.56#L47
A little easier on the eyes, imho.
Regards,
Daniel
next prev parent reply other threads:[~2003-06-09 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 9:39 [RFC] device-mapper ioctl interface Joe Thornber
2003-06-05 16:47 ` Kevin Corry
2003-06-05 17:00 ` [dm-devel] " Daniel Phillips
2003-06-05 17:50 ` Kevin Corry
2003-06-05 18:53 ` Daniel Phillips
2003-06-05 19:41 ` Joe Thornber
2003-06-06 16:11 ` Kevin Corry
2003-06-06 17:17 ` Greg KH
2003-06-06 19:53 ` [dm-devel] " Alasdair G Kergon
2003-06-09 20:03 ` Daniel Phillips [this message]
2003-06-09 20:39 ` Greg KH
2003-06-09 21:39 ` Daniel Phillips
2003-06-09 22:08 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306092203.50024.dphillips@sistina.com \
--to=dphillips@sistina.com \
--cc=dm-devel@sistina.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.