From: Jens Axboe <axboe@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] loop 2/9 absorb bio_copy
Date: Tue, 10 Jun 2003 17:37:30 +0200 [thread overview]
Message-ID: <20030610153730.GC17164@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0306101630210.2285-100000@localhost.localdomain>
On Tue, Jun 10 2003, Hugh Dickins wrote:
> bio_copy is used only by the loop driver, which already has to walk the
> bio segments itself: so it makes sense to change it from bio.c export
> to loop.c static, as prelude to working upon it there.
>
> bio_copy itself is unchanged by this patch, with one exception. On oom
> failure it must use bio_put, instead of mempool_free to static bio_pool:
> which it should have been doing all along - it was leaking the veclist.
I don't think this is is a particularly good idea, it's pretty core bio
functionality that should be left alone in bio.c imho.
Is there a real reason you want to do this apart from 'loop is the only
(current) user'?
--
Jens Axboe
next prev parent reply other threads:[~2003-06-10 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-10 15:30 [PATCH] loop 1/9 file use highmem Hugh Dickins
2003-06-10 15:31 ` [PATCH] loop 2/9 absorb bio_copy Hugh Dickins
2003-06-10 15:37 ` Jens Axboe [this message]
2003-06-10 16:02 ` Hugh Dickins
2003-06-10 16:01 ` Jens Axboe
2003-06-10 15:31 ` [PATCH] loop 3/9 loop bio renaming Hugh Dickins
2003-06-10 15:32 ` [PATCH] loop 4/9 copy bio not data Hugh Dickins
2003-06-10 15:33 ` [PATCH] loop 5/9 remove an IV Hugh Dickins
2003-06-10 15:34 ` [PATCH] loop 6/9 remove LO_FLAGS_BH_REMAP Hugh Dickins
2003-06-10 15:42 ` Jens Axboe
2003-06-10 15:35 ` [PATCH] loop 7/9 remove blk_queue_bounce Hugh Dickins
2003-06-10 15:37 ` [PATCH] loop 8/9 copy_bio use highmem Hugh Dickins
2003-06-10 15:38 ` [PATCH] loop 9/9 don't lose PF_MEMDIE Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030610153730.GC17164@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.