From: Jens Axboe <axboe@suse.de>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IDE Power Management, try 2
Date: Tue, 10 Jun 2003 19:28:11 +0200 [thread overview]
Message-ID: <20030610172811.GI17164@suse.de> (raw)
In-Reply-To: <Pine.SOL.4.30.0306101832350.24343-100000@mion.elka.pw.edu.pl>
On Tue, Jun 10 2003, Bartlomiej Zolnierkiewicz wrote:
>
> On 10 Jun 2003, Benjamin Herrenschmidt wrote:
>
> > On Tue, 2003-06-10 at 18:15, Jens Axboe wrote:
> > > On Thu, Jun 05 2003, Bartlomiej Zolnierkiewicz wrote:
> > > > Jens, I think generic version of ide_do_drive_cmd() would be useful for
> > > > other block devices, what do you think?
> > >
> > > Something ala this? Completely untested, and I only did scsi_ioctl.c and
> > > ide-io.c. iirc, scsi uses somthing similar that could be adapted too.
> >
> > Hrm... you didn't keep some functionalities I added with the PM
> > patch here... like marking of preempt requests so I can fetch them
> > even when drive is blocked, and ide_head_wait...
> >
> > Ben
>
> I've looked for users of ide_preempt in drivers/ide/ and I think
> that REQ_PREEMPT can later die if we fix drivers to correctly mark
> sense requests with REQ_SENSE...
Indeed, besides preempt is not really something you can do completely
in the block layer safely. So I'd rather kill that logic.
--
Jens Axboe
prev parent reply other threads:[~2003-06-10 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 13:46 [PATCH] IDE Power Management, try 2 Benjamin Herrenschmidt
2003-06-05 14:16 ` Bartlomiej Zolnierkiewicz
2003-06-05 14:27 ` Benjamin Herrenschmidt
2003-06-05 14:30 ` Benjamin Herrenschmidt
2003-06-06 4:35 ` Jens Axboe
2003-06-07 1:55 ` Andre Hedrick
2003-06-10 16:15 ` Jens Axboe
2003-06-10 16:27 ` Benjamin Herrenschmidt
2003-06-10 16:36 ` Bartlomiej Zolnierkiewicz
2003-06-10 16:58 ` Benjamin Herrenschmidt
2003-06-10 17:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030610172811.GI17164@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.