From: Dave Jones <davej@codemonkey.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] And yet more PCI fixes for 2.5.70
Date: Wed, 11 Jun 2003 13:53:33 +0100 [thread overview]
Message-ID: <20030611125333.GA1241@suse.de> (raw)
In-Reply-To: <1055335057.2083.14.camel@dhcp22.swansea.linux.org.uk>
On Wed, Jun 11, 2003 at 01:37:37PM +0100, Alan Cox wrote:
> On Mer, 2003-06-11 at 01:11, Greg KH wrote:
> > /* user supplied value */
> > system_bus_speed = idebus_parameter;
> > - } else if (pci_present()) {
> > + } else if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) != NULL) {
>
> That is just gross. pci_present() is far more readable even if you make
> it an inline in pci.h that is pci_find_device(PCI_ANY_ID, PCI_ANY_ID,
> NULL)
That was my argument I was trying to get across with the previous
lot of ugly PCI changes. I lost that one, and lost the will to fight
this one.
Dave
next prev parent reply other threads:[~2003-06-11 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 0:11 [BK PATCH] And yet more PCI fixes for 2.5.70 Greg KH
2003-06-11 0:11 ` [PATCH] " Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 12:37 ` Alan Cox
2003-06-11 12:47 ` Christoph Hellwig
2003-06-11 12:53 ` Dave Jones [this message]
2003-06-11 16:38 ` Greg KH
2003-06-11 17:19 ` Alan Cox
2003-06-11 17:46 ` Jeff Garzik
2003-06-11 19:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030611125333.GA1241@suse.de \
--to=davej@codemonkey.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.