Re: [PATCH] Synaptics TouchPad driver for 2.5.70

[Vojtech Pavlik <vojtech@ucw.cz>]

On Wed, Jun 11, 2003 at 07:05:31AM +0200, Peter Osterlund wrote:
> [ I'm resending this because the previous message never showed up on
> the list. Maybe it was too big. ]
> 
> Hi!
> 
> Here is a driver for the Synaptics TouchPad for 2.5.70. It is largely
> based on the XFree86 driver. This driver operates the touchpad in
> absolute mode and emulates a three button mouse with two scroll
> wheels. Features include:
> 
> * Multi finger tapping.
> * Vertical and horizontal scrolling.
> * Edge scrolling during drag operations.
> * Palm detection.
> * Corner tapping.
> 
> The only major missing feature is runtime configuration of driver
> parameters. What is the best way to implement that?

sysfs, of course.

> I was thinking of
> sending EV_MSC events to the driver using the /dev/input/event*
> interface and define my own codes for the different driver parameters.

No, not that ... 

> The patch is available here:
> 
>         http://w1.894.telia.com/~u89404340/patches/synaptics_driver.patch
> 
> Comments?

IMO it should use ABS_ events and the relativization should be done in
the XFree86 driver. Other than that, it looks quite OK.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR