From: Patrick Mansfield <patmans@us.ibm.com>
To: Ben Collins <bcollins@debian.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Torrey Hoffman <thoffman@arnor.net>,
linux-scsi@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: scsi_add_device() broken? (was Re: SBP2 hotplug doesn't update /proc/partitions)
Date: Fri, 13 Jun 2003 10:19:43 -0700 [thread overview]
Message-ID: <20030613101943.A22559@beaverton.ibm.com> (raw)
In-Reply-To: <20030613160812.GA520@hopper.phunnypharm.org>; from bcollins@debian.org on Fri, Jun 13, 2003 at 12:08:12PM -0400
On Fri, Jun 13, 2003 at 12:08:12PM -0400, Ben Collins wrote:
> Here's the scenario. scsi_add_lun doesn't set sdp->devfs_name before
> calling scsi_register_device(). Since scsi_register_device calls down to
> things like sd_probe, which do try to use sdp->devfs_name, things fail.
>
> Just an easy change, moving the sdp->devfs_name creation before calling
> scsi_register_device(). Patch fixes this.
It really needs to move into the caller of scsi_add_lun, so we setup all
the other fields, and possibly call scsi_unlock_floptical before
registering.
And the return value should be checked - then on failure just set res (in
scsi_probe_and_add_lun) so it is cleaned up.
-- Patrick Mansfield
next prev parent reply other threads:[~2003-06-13 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 23:48 Another must-fix: sbp2 and firewire hard disk crashes hard Torrey Hoffman
2003-06-04 23:55 ` Andrew Morton
[not found] ` <1054838369.1737.11.camel@torrey.et.myrio.com>
[not found] ` <20030605175412.GF625@phunnypharm.org>
[not found] ` <1054858724.3519.19.camel@torrey.et.myrio.com>
[not found] ` <20030606025721.GJ625@phunnypharm.org>
2003-06-12 19:28 ` SBP2 hotplug doesn't update /proc/partitions Torrey Hoffman
2003-06-12 19:52 ` Erik Andersen
2003-06-12 20:07 ` Torrey Hoffman
2003-06-12 19:52 ` Ben Collins
2003-06-13 2:40 ` scsi_add_device() broken? (was Re: SBP2 hotplug doesn't update /proc/partitions) Ben Collins
2003-06-13 4:38 ` B. D. Elliott
2003-06-13 16:08 ` [PATCH] " Ben Collins
2003-06-13 17:19 ` Patrick Mansfield [this message]
2003-06-12 20:21 ` SBP2 hotplug doesn't update /proc/partitions Torrey Hoffman
2003-06-05 8:03 ` Another must-fix: sbp2 and firewire hard disk crashes hard Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030613101943.A22559@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thoffman@arnor.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.