From: Richard Henderson <rth@twiddle.net>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, ak@muc.de,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters
Date: Sun, 15 Jun 2003 17:49:57 -0700 [thread overview]
Message-ID: <20030616004957.GA15350@twiddle.net> (raw)
In-Reply-To: <20030616002453.8A9B72C078@lists.samba.org>
On Mon, Jun 16, 2003 at 10:23:41AM +1000, Rusty Russell wrote:
> Since Andi reports that even that doesn't work for x86-64, I'd say
> apply this patch based on his: it's an arbitrary change anyway.
No, Andi located the *real* problem. The compiler was over-aligning
these objects, which added padding, which broke the array semantics
you were looking for. The solution is to add an attribute aligned;
he's sent a patch to Linus already.
r~
next prev parent reply other threads:[~2003-06-16 0:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 12:58 [PATCH] Fix undefined/miscompiled construct in kernel parameters Andi Kleen
2003-06-15 16:52 ` Linus Torvalds
2003-06-16 0:23 ` Rusty Russell
2003-06-16 0:49 ` Richard Henderson [this message]
2003-06-16 3:55 ` Rusty Russell
2003-06-16 2:44 ` Linus Torvalds
[not found] <20030615131004$6a85@gated-at.bofh.it>
[not found] ` <20030615170013$4ebc@gated-at.bofh.it>
2003-06-15 17:17 ` Andi Kleen
2003-06-15 17:24 ` Linus Torvalds
2003-06-15 17:32 ` Andi Kleen
2003-06-15 17:48 ` Roman Zippel
2003-06-15 18:28 ` Andi Kleen
2003-06-15 22:56 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616004957.GA15350@twiddle.net \
--to=rth@twiddle.net \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.