From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@muc.de, netdev@oss.sgi.com, mostrows@speakeasy.net, paulus@au.ibm.com
Subject: Re: [PATCH] Convert pppoe to new style protocol
Date: Wed, 18 Jun 2003 10:01:18 +0200 [thread overview]
Message-ID: <20030618080118.GC23037@wotan.suse.de> (raw)
In-Reply-To: <20030617.150751.52901849.davem@redhat.com>
On Tue, Jun 17, 2003 at 03:07:51PM -0700, David S. Miller wrote:
> From: Andi Kleen <ak@muc.de>
> Date: Wed, 18 Jun 2003 00:04:20 +0200
>
> Convert pppoe to a new style protocol, otherwise it is unusable
> on SMP compiled kernels because of the printk in deliver*old_ones.
> It works fine here, but only tested on a UP box.
>
> Please don't add new skb_linearize() users, I'm trying
> to make that only local to net/core/dev.c
Then offer a flag or something for protocols that also doesn't trigger
printks ?
>
> Otherwise I'm fine with your patch.
How else should it be done?
I'm not going through the whole PPP layer now to audit it for non linear
skb cleanliness...
-Andi
next prev parent reply other threads:[~2003-06-18 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 22:04 [PATCH] Convert pppoe to new style protocol Andi Kleen
2003-06-17 22:07 ` David S. Miller
2003-06-18 8:01 ` Andi Kleen [this message]
2003-06-18 12:21 ` Werner Almesberger
2003-06-18 12:51 ` Andi Kleen
2003-06-18 17:21 ` David S. Miller
2003-06-18 23:36 ` David S. Miller
2003-06-18 17:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030618080118.GC23037@wotan.suse.de \
--to=ak@suse.de \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=mostrows@speakeasy.net \
--cc=netdev@oss.sgi.com \
--cc=paulus@au.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.