All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nye Liu <nyet@mrv.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] FADS and ICU862 Environment problems
Date: Thu, 19 Jun 2003 18:45:30 -0700	[thread overview]
Message-ID: <20030620014530.GA21955@zumanetworks.com> (raw)

The current FADS code does not seem to restore the environment properly,
and i can't figure out what it SHOULD do.

Right now, relocate_code only relocates up to the end of text
(_init_end), and since CFG_MONITOR_BASE + CONFIG_MONITOR_LEN is after
CFG_ENV_ADDR, ENV_IS_EMBEDDED is set.

Since ENV_IS_EMBEDDED is set, env_reloca_spec in flash.c does NOT
memcpy(env_addr,CFG_ENV_ADDR,CFG_ENV_SIZE).

There are several refereces to environment[] in start.S that are
ifdefed out if CONFIG_FADS or CONFIG_ICU862, which don't look right.

My fix is to remove those ifdefs, and make sure that ENV_IS_EMBEDDED
is NOT set by reducing CFG_MONITOR_LEN to not include the environment.

What is the correct behavior?

TIA

-- 
Nye Liu
nliu at mrv.com
(818) 772-6235x248

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote

             reply	other threads:[~2003-06-20  1:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-20  1:45 Nye Liu [this message]
2003-06-21  0:21 ` [U-Boot-Users] FADS and ICU862 Environment problems Wolfgang Denk
2003-06-21  0:28   ` Nye Liu
2003-06-22 16:22     ` Wolfgang Denk
2003-06-23 21:25       ` Nye Liu
2003-06-23 21:35         ` Wolfgang Denk
2003-06-23 21:42           ` Nye Liu
2003-06-24 18:24             ` Wolfgang Denk
2003-06-24 20:28               ` Nye Liu
2003-06-24 20:38                 ` Wolfgang Denk
2003-06-24 23:59                   ` Nye Liu
2003-06-26  6:50                     ` Wolfgang Denk
2003-06-26 21:40                       ` Nye Liu
2003-06-26 22:03                         ` Wolfgang Denk
2003-06-26 22:10                           ` Nye Liu
2003-06-26 22:31                             ` Wolfgang Denk
2003-06-26 22:41                               ` Nye Liu
2003-06-26 23:10                                 ` Wolfgang Denk
2003-06-27 21:27                                   ` Nye Liu
2003-06-27  3:47                               ` [U-Boot-Users] a small problem Yabo Ding
2003-06-27  6:51                                 ` [U-Boot-Users] " Wolfgang Denk
2003-06-27  7:56                                   ` Yabo Ding
2003-06-25  0:27       ` [U-Boot-Users] FADS and ICU862 Environment problems Nye Liu
2003-06-26  6:53         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030620014530.GA21955@zumanetworks.com \
    --to=nyet@mrv.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.