From: viro@parcelfarce.linux.theplanet.co.uk
To: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VFS autmounter support v3
Date: Fri, 20 Jun 2003 17:37:55 +0100 [thread overview]
Message-ID: <20030620163755.GH6754@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <25482.1056125836@warthog.warthog>
On Fri, Jun 20, 2003 at 05:17:16PM +0100, David Howells wrote:
> (2) Automatic mount point expiry. This allows any mountpoint to be given a
> timeout, such that when mntput() detects that the vfsmount is only used
> by its parent, a work chitty will be enqueued to cause the containing
> namespace to be vacuumed later for dead mounts.
Broken.
a) it doesn't scale. A single expirable mountpoint and we will be
walking potentially very long list.
b) the logics is wrong - you are scheduling "let's go and expire
stuff" when ->mnt_count drops far enough; put something like /usr/share
on a separate fs and observe what happens to ->mnt_count. It will touch
the trigger value very often. Better yet, do that with /usr/include and
start a big build. You will have your expiry code triggered all the time,
even though fs is in very active use.
prev parent reply other threads:[~2003-06-20 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-20 16:17 [PATCH] VFS autmounter support v3 David Howells
2003-06-20 16:37 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030620163755.GH6754@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.