From: Christoph Hellwig <hch@infradead.org>
To: Andries.Brouwer@cwi.nl
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] loop.c - part 1 of many
Date: Mon, 23 Jun 2003 06:21:37 +0100 [thread overview]
Message-ID: <20030623062137.A24311@infradead.org> (raw)
In-Reply-To: <UTC200306230127.h5N1RpE13973.aeb@smtp.cwi.nl>; from Andries.Brouwer@cwi.nl on Mon, Jun 23, 2003 at 03:27:51AM +0200
On Mon, Jun 23, 2003 at 03:27:51AM +0200, Andries.Brouwer@cwi.nl wrote:
> -static int figure_loop_size(struct loop_device *lo)
> +static int
> +figure_loop_size(struct loop_device *lo)
This moves away from Documentation/CondingStyle..
> int loop_register_transfer(struct loop_func_table *funcs)
> {
> - if ((unsigned)funcs->number > MAX_LO_CRYPT || xfer_funcs[funcs->number])
> + unsigned int n = funcs->number;
> +
> + if (n >= MAX_LO_CRYPT || xfer_funcs[n])
> return -EINVAL;
> - xfer_funcs[funcs->number] = funcs;
> - return 0;
> + xfer_funcs[n] = funcs;
> + return 0;
> }
Once you start touching loop_{,un}register_transfer please also get
rid of the array in favour of a linked list..
next prev parent reply other threads:[~2003-06-23 5:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 1:27 [PATCH] loop.c - part 1 of many Andries.Brouwer
2003-06-23 1:47 ` viro
2003-06-23 5:21 ` Christoph Hellwig [this message]
2003-06-23 16:14 ` [Q] loop.c Paul P Komkoff Jr
2003-06-23 23:27 ` Andries Brouwer
2003-06-24 5:26 ` Paul P Komkoff Jr
-- strict thread matches above, loose matches on Subject: below --
2003-06-23 8:40 [PATCH] loop.c - part 1 of many Andries.Brouwer
2003-06-23 8:44 ` Christoph Hellwig
2003-06-23 8:47 Andries.Brouwer
2003-06-23 8:49 ` Christoph Hellwig
2003-06-23 8:59 Andries.Brouwer
2003-06-23 14:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623062137.A24311@infradead.org \
--to=hch@infradead.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.