From: Anton Blanchard <anton@samba.org>
To: Matthew Wilcox <willy@debian.org>
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [RFC] pci_name()
Date: Thu, 26 Jun 2003 11:09:32 +1000 [thread overview]
Message-ID: <20030626010932.GA674@krispykreme> (raw)
In-Reply-To: <20030625233525.GB451@parcelfarce.linux.theplanet.co.uk>
> I'd kind of like to get rid of pci_dev->slot_name. It's redundant with
> pci_dev->dev.bus_id, but that's one hell of a search and replace job.
> So let me propose pci_name(pci_dev) as a replacement. That has the
> benefit of being shorter than either of the others and lets us do fun
> & interesting things later (maybe construct it on the fly for systems
> that want to save 20 bytes per device?). We can transition it in over
> 2.5/2.6/2.7 and kill pci_dev->slot_name for 2.8.
>
> Oh, and without killing slot_name immediately, we can save 4 bytes on
> 32-bit platforms by turning it into a pointer to the dev.bus_id.
Works for me, I wanted to hijack pci_dev->slot_name (or the equivalent) so
we print both domain:bus:devfn as well as the system location on ppc64.
The system location makes it easier to work out which slot the card is in.
I dont necessarily need pci_name() since I could do what I want if
pci_dev->slot_name becomes a pointer.
Anton
prev parent reply other threads:[~2003-06-26 1:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-25 23:35 [RFC] pci_name() Matthew Wilcox
2003-06-26 0:21 ` Jeff Garzik
2003-06-26 0:36 ` Greg KH
2003-06-26 0:53 ` Matthew Wilcox
2003-06-26 1:02 ` Greg KH
2003-06-26 2:50 ` Matthew Wilcox
2003-06-26 2:52 ` Matthew Wilcox
2003-06-26 11:20 ` Matthew Wilcox
2003-06-26 1:09 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030626010932.GA674@krispykreme \
--to=anton@samba.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.