All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: jsalmon@thesalmons.org
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
	kuznet@ms2.inr.ac.ru, jmorris@redhat.com
Subject: Re: negative tcp_tw_count and other TIME_WAIT weirdness?
Date: Tue, 01 Jul 2003 01:21:07 -0700 (PDT)	[thread overview]
Message-ID: <20030701.012107.42800729.davem@redhat.com> (raw)
In-Reply-To: <200307010025.h610PGmX007656@river.fishnet>

   From: John Salmon <jsalmon@thesalmons.org>
   Date: Mon, 30 Jun 2003 17:25:16 -0700

   I have several fairly busy servers reporting a negative value
   for tcp_tw_count.

 I have a sneaking suspicion that this patch (already in 2.4.22-preX)
 will fix your problem.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.930.114.22 -> 1.930.114.23
#	net/ipv4/tcp_minisocks.c	1.13    -> 1.14   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/07	olof@austin.ibm.com	1.930.114.23
# [TCP]: tcp_twkill leaves death row list in inconsistent state over tcp_timewait_kill.
# --------------------------------------------
#
diff -Nru a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
--- a/net/ipv4/tcp_minisocks.c	Tue Jul  1 01:25:26 2003
+++ b/net/ipv4/tcp_minisocks.c	Tue Jul  1 01:25:26 2003
@@ -447,6 +447,8 @@
 
 	while((tw = tcp_tw_death_row[tcp_tw_death_row_slot]) != NULL) {
 		tcp_tw_death_row[tcp_tw_death_row_slot] = tw->next_death;
+		if (tw->next_death)
+			tw->next_death->pprev_death = tw->pprev_death;
 		tw->pprev_death = NULL;
 		spin_unlock(&tw_death_lock);
 

  reply	other threads:[~2003-07-01  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-01  0:25 negative tcp_tw_count and other TIME_WAIT weirdness? John Salmon
2003-07-01  8:21 ` David S. Miller [this message]
2003-07-01 17:12   ` John Salmon
2003-07-01 17:15     ` Nivedita Singhvi
2003-07-01 21:22       ` John Salmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030701.012107.42800729.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=jmorris@redhat.com \
    --cc=jsalmon@thesalmons.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.