All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	trivial@rustcorp.com.au
Subject: [patch] 2.5.74: i2o_scsi.c must include pci.h
Date: Thu, 3 Jul 2003 18:14:29 +0200	[thread overview]
Message-ID: <20030703161429.GN282@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0307021433520.2323-100000@home.osdl.org>

I got the following compile error with 2.5.74:

<--  snip  -->

...
  CC      drivers/message/i2o/i2o_scsi.o
drivers/message/i2o/i2o_scsi.c: In function `i2o_scsi_reply':
drivers/message/i2o/i2o_scsi.c:327: warning: implicit declaration of 
function `pci_unmap_sg'
drivers/message/i2o/i2o_scsi.c:329: warning: implicit declaration of 
function `pci_unmap_single'
drivers/message/i2o/i2o_scsi.c: In function `i2o_scsi_queuecommand':
drivers/message/i2o/i2o_scsi.c:763: warning: implicit declaration of 
function `pci_map_sg'
drivers/message/i2o/i2o_scsi.c:833: warning: implicit declaration of 
function `pci_map_single'
...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x5e871c): In function `i2o_scsi_reply':
: undefined reference to `pci_unmap_single'
drivers/built-in.o(.text+0x5e873c): In function `i2o_scsi_reply':
: undefined reference to `pci_unmap_sg'
drivers/built-in.o(.text+0x5e9471): In function `i2o_scsi_queuecommand':
: undefined reference to `pci_map_sg'
drivers/built-in.o(.text+0x5e9781): In function `i2o_scsi_queuecommand':
: undefined reference to `pci_map_single'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The fix is simple:


--- linux-2.5.74-not-full/drivers/message/i2o/i2o_scsi.c.old	2003-07-03 17:59:18.000000000 +0200
+++ linux-2.5.74-not-full/drivers/message/i2o/i2o_scsi.c	2003-07-03 18:00:11.000000000 +0200
@@ -49,6 +49,7 @@
 #include <linux/delay.h>
 #include <linux/proc_fs.h>
 #include <linux/prefetch.h>
+#include <linux/pci.h>
 #include <asm/dma.h>
 #include <asm/system.h>
 #include <asm/io.h>



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-07-03 16:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-02 21:36 Linux 2.5.74 Linus Torvalds
2003-07-02 22:58 ` Dagfinn Ilmari Mannsåker
2003-07-02 23:45 ` Linux 2.5.74: BUG at mm/slab.c:1537 Andy Pfiffer
2003-07-03 10:18 ` 2.5.74: aha1740.c doesn't compile Adrian Bunk
2003-07-03 12:03   ` Marc Zyngier
2003-07-03 14:27     ` Adrian Bunk
2003-07-03 15:16       ` Marc Zyngier
2003-07-03 16:14 ` Adrian Bunk [this message]
2003-07-03 22:20 ` Linux 2.5.74 (compile statistics) John Cherry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030703161429.GN282@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.