From: Michael Buesch <fsdeveloper@yahoo.de>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Hardly triggered tests in bootmem.c ...
Date: Thu, 3 Jul 2003 16:46:07 +0200 [thread overview]
Message-ID: <200307031646.18127.fsdeveloper@yahoo.de> (raw)
In-Reply-To: <Pine.LNX.4.55.0307021503490.4840@bigblue.dev.mcafeelabs.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thursday 03 July 2003 00:07, Davide Libenzi wrote:
> I was looking at the bootmem.c source and I found those hardly triggered
> tests (unsigned long's).
> (Andrew, sending the patch insted of the note)
>
>
> - Davide
>
>
>
>
> --- linux-2.5.73/mm/bootmem.c.orig 2003-07-02 14:55:47.000000000 -0700
> +++ linux-2.5.73/mm/bootmem.c 2003-07-02 14:56:51.000000000 -0700
> @@ -84,10 +84,6 @@
>
> if (!size) BUG();
>
> - if (sidx < 0)
> - BUG();
> - if (eidx < 0)
> - BUG();
> if (sidx >= eidx)
> BUG();
> if ((addr >> PAGE_SHIFT) >= bdata->node_low_pfn)
shouldn't we convert the remaining
if (x)
BUG();
to
BUG_ON(x)
?
- --
Regards Michael Buesch
http://www.8ung.at/tuxsoft
16:44:38 up 1:00, 1 user, load average: 1.00, 1.00, 0.95
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE/BEG6oxoigfggmSgRAuFAAJ4iJfEdI5J+SBrDQ9CZM3eEwDC6iwCcDyL7
ssuTGbtylaaqagOLLtYi3ds=
=4xv5
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2003-07-03 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 22:07 [patch] Hardly triggered tests in bootmem.c Davide Libenzi
2003-07-03 14:46 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307031646.18127.fsdeveloper@yahoo.de \
--to=fsdeveloper@yahoo.de \
--cc=akpm@osdl.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.