From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Smalley <sds@epoch.ncsc.mil>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Chris Wright <chris@wirex.com>,
James Morris <jmorris@intercode.com.au>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add SELinux module to 2.5.74-bk1
Date: Thu, 3 Jul 2003 13:51:53 -0400 [thread overview]
Message-ID: <20030703175153.GC27556@gtf.org> (raw)
In-Reply-To: <1057254295.1110.1016.camel@moss-huskers.epoch.ncsc.mil>
On Thu, Jul 03, 2003 at 01:44:55PM -0400, Stephen Smalley wrote:
> The patch against 2.5.74-bk1 available from
> http://www.nsa.gov/selinux/lk/2.5.74-bk1-selinux.patch.gz adds the
> SELinux module to the tree and modifies the security/Makefile and
> security/KConfig files for SELinux. The last dependency for SELinux,
> the vm_enough_memory security hook, was included in -bk1. Please
> consider applying. Thanks. diffstat output is below.
nitpicks:
1) "selinux" is a poor toplevel directory. We already have the toplevel
"security" directory, this code should go in there.
2) stick includes in the standard include/ directory. I would suggest
include/security (if the headers are general) or
include/security/selinux.
3) I wonder if the kernel should have a generic hash table ADT?
Jeff
next prev parent reply other threads:[~2003-07-03 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 17:44 [PATCH] Add SELinux module to 2.5.74-bk1 Stephen Smalley
2003-07-03 17:51 ` Jeff Garzik [this message]
2003-07-03 17:55 ` Chris Wright
2003-07-03 17:56 ` Greg KH
2003-07-03 18:05 ` Stephen Smalley
2003-07-04 15:41 ` Jeff Garzik
2003-07-08 9:49 ` James Morris
2003-07-08 10:09 ` Andrew Morton
2003-07-08 13:20 ` James Morris
2003-07-08 13:45 ` Alan Cox
2003-07-08 15:00 ` James Morris
2003-07-08 11:33 ` Christoph Hellwig
2003-07-08 13:50 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030703175153.GC27556@gtf.org \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chris@wirex.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.