From: "David S. Miller" <davem@redhat.com>
To: hch@infradead.org
Cc: jmorris@intercode.com.au, TSPAT@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: crypto API and IBM z990 hardware support
Date: Mon, 07 Jul 2003 19:53:50 -0700 (PDT) [thread overview]
Message-ID: <20030707.195350.39170946.davem@redhat.com> (raw)
In-Reply-To: <20030707080929.A1848@infradead.org>
From: Christoph Hellwig <hch@infradead.org>
Date: Mon, 7 Jul 2003 08:09:29 +0100
On Wed, Jul 02, 2003 at 07:35:16PM +1000, James Morris wrote:
> So, there might be:
>
> crypto/aes.c
> crypto/arch/i386/aes.s
crypto/arch/ sounds like a bad idea. We really should avoid arch code
outside arch/ and include/asm*. So arch/<foo>/crypto/ as suggested by
Thomas is much better.
I totally disagree. I think the way we do things today is _STUPID_.
We put arch code far away from the generic version which makes finding
stuff very difficult for people inspecting the code for the first time.
For example, the fact that I have to go groveling in
arch/foo/lib/whoknowswhatfile.whoknowswhatextension to look at
the memcpy/checksum/whatever implementation is completely busted.
So, I totally support making crypto/arch/ directories.
next prev parent reply other threads:[~2003-07-08 2:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 7:07 crypto API and IBM z990 hardware support Thomas Spatzier
2003-07-02 9:35 ` James Morris
2003-07-07 7:09 ` Christoph Hellwig
2003-07-08 2:53 ` David S. Miller [this message]
2003-07-08 3:37 ` Roland Dreier
2003-07-08 3:35 ` David S. Miller
2003-07-10 1:08 ` Werner Almesberger
2003-07-10 1:08 ` David S. Miller
2003-07-10 2:06 ` Werner Almesberger
2003-07-10 2:06 ` David S. Miller
2003-07-10 2:37 ` Werner Almesberger
2003-07-11 0:02 ` David S. Miller
[not found] ` <mailman.1057799700.15422.linux-kernel2news@redhat.com>
2003-07-10 5:55 ` Pete Zaitcev
-- strict thread matches above, loose matches on Subject: below --
2003-07-02 12:35 Thomas Spatzier
2003-07-02 16:57 ` James Morris
2003-07-07 7:11 ` Christoph Hellwig
2003-07-07 10:27 ` James Morris
2003-07-02 20:23 Ulrich Weigand
[not found] <4P45.5YN.11@gated-at.bofh.it>
[not found] ` <4T81.24d.41@gated-at.bofh.it>
2003-07-02 22:06 ` Arnd Bergmann
2003-07-06 14:08 ` James Morris
2003-07-06 17:46 ` Arnd Bergmann
2003-07-07 7:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030707.195350.39170946.davem@redhat.com \
--to=davem@redhat.com \
--cc=TSPAT@de.ibm.com \
--cc=hch@infradead.org \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.