From: Jeff Garzik <jgarzik@pobox.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Christoph Hellwig <hch@infradead.org>,
marcelo@connectiva.com.br, lkml <linux-kernel@vger.kernel.org>
Subject: Re: ->direct_IO API change in current 2.4 BK
Date: Wed, 9 Jul 2003 15:18:47 -0400 [thread overview]
Message-ID: <20030709191847.GI15293@gtf.org> (raw)
In-Reply-To: <20030709115148.L4482@schatzie.adilger.int>
On Wed, Jul 09, 2003 at 11:51:48AM -0700, Andreas Dilger wrote:
> On Jul 09, 2003 20:29 +0200, Trond Myklebust wrote:
> > How about instead following Alan's suggestion to replace
> > KERNEL_HAS_O_DIRECT with a KERNEL_HAS_O_DIRECT2 that can be used to
> > switch between the old and new O_DIRECT format in the XFS patches?
>
> Actually, I like that a lot more, as it allows out-of-tree code to
> know which interface to use, and we don't have to key on kernel version
> (which is bogus if compiling against a vendor kernel that back-ports
> this fix).
Feature test macros are definitely quite useful...
...but making the stable series VFS API definition _conditional_
is quite unprecedented, and IMO wrong.
Jeff
prev parent reply other threads:[~2003-07-09 19:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 12:31 ->direct_IO API change in current 2.4 BK Christoph Hellwig
2003-07-09 17:03 ` Andreas Dilger
2003-07-09 17:24 ` Marcelo Tosatti
2003-07-09 17:43 ` Marc-Christian Petersen
2003-07-09 17:46 ` Marcelo Tosatti
2003-07-09 17:55 ` Marc-Christian Petersen
2003-07-09 18:08 ` Marcelo Tosatti
2003-07-09 18:22 ` Marc-Christian Petersen
2003-07-09 19:13 ` Marcelo Tosatti
2003-07-09 19:45 ` Marc-Christian Petersen
2003-07-09 23:43 ` Alan Cox
2003-07-10 0:21 ` Jeff Garzik
2003-07-09 18:33 ` Trond Myklebust
2003-07-09 18:41 ` Marc-Christian Petersen
2003-07-09 18:50 ` Trond Myklebust
2003-07-09 18:55 ` Marc-Christian Petersen
2003-07-09 19:05 ` Jeff Garzik
2003-07-09 19:08 ` Trond Myklebust
2003-07-09 19:17 ` Jeff Garzik
2003-07-09 19:51 ` Trond Myklebust
2003-07-09 21:43 ` Jeff Garzik
2003-07-09 23:42 ` Alan Cox
2003-07-10 0:23 ` Jeff Garzik
2003-07-09 23:40 ` Alan Cox
2003-07-09 18:29 ` Trond Myklebust
2003-07-09 18:51 ` Andreas Dilger
2003-07-09 19:18 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030709191847.GI15293@gtf.org \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=marcelo@connectiva.com.br \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.