From: Greg KH <greg@kroah.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] timer clean up for i2c-keywest.c
Date: Wed, 9 Jul 2003 20:56:11 -0700 [thread overview]
Message-ID: <20030710035611.GD1561@kroah.com> (raw)
In-Reply-To: <1057744088.506.8.camel@gaston>
On Wed, Jul 09, 2003 at 11:48:08AM +0200, Benjamin Herrenschmidt wrote:
> On Tue, 2003-07-08 at 12:26, Benjamin Herrenschmidt wrote:
> > On Mon, 2003-07-07 at 09:03, Paul Mackerras wrote:
> > > This patch changes i2c-keywest.c to use mod_timer instead of a
> > > two-line sequence to compute .expires and call add_timer in 3 places.
> > > Without this patch I get a BUG from time to time in add_timer.
> >
> > Ok, here it is. It also remove the never used "polled" mode. The
> > driver is now in sync with the more up-to-date 2.4 version ;)
> >
> > Sorry for not sending that earlier, I forgot about it and didn't
> > notice it was out of sync.
>
> And just in case you didn't merge it yet... Here's a version changing
> the timer->expire ; add_timer() pairs into calls to mod_timer, makes
> the code slighly cleaner.
Thanks, I've applied this one.
greg k-h
prev parent reply other threads:[~2003-07-10 3:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-07 7:03 [PATCH] timer clean up for i2c-keywest.c Paul Mackerras
2003-07-08 10:15 ` Benjamin Herrenschmidt
2003-07-08 10:26 ` Benjamin Herrenschmidt
2003-07-09 9:48 ` Benjamin Herrenschmidt
2003-07-10 3:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030710035611.GD1561@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.