All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Jan Dittmer <j.dittmer@portrix.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: agpgart, nforce2, radeon and agp fastwrite
Date: Sat, 12 Jul 2003 22:17:21 +0100	[thread overview]
Message-ID: <20030712211721.GA10207@suse.de> (raw)
In-Reply-To: <3F10793E.5080202@portrix.net>

On Sat, Jul 12, 2003 at 11:10:22PM +0200, Jan Dittmer wrote:
 > Forgot to mention I had to use this patchlet to get nvidia-agp to link 
 > properly.
 > 
 > Jan
 > 
 > --- linux-mm/drivers/char/agp/generic.c Thu Jul  3 15:04:06 2003
 > +++ 2.5.73-mm3/drivers/char/agp/generic.c       Wed Jul  9 10:04:34 2003
 > @@ -39,7 +39,7 @@
 > 
 >  __u32 *agp_gatt_table;
 >  int agp_memory_reserved;
 > -
 > +EXPORT_SYMBOL(agp_memory_reserved)


Girr. I'm not entirely happy about exporting that if I can help it.
It's annoying that the nvidia_insert_memory() routine is 99% the same
as the generic routine. If it could use that, we'd not have to worry
about the export.

A possible fix could be teaching the generic routine about offsets
where the table really begins in the GART. (nforce wants a 64MB GART
for a 32MB aperture, and needs to begin at some wierd offset..

Let me think a little on this one before merging that export.

	Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk

  reply	other threads:[~2003-07-12 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-12 15:51 agpgart, nforce2, radeon and agp fastwrite Jan Dittmer
2003-07-12 20:26 ` Dave Jones
2003-07-12 21:10   ` Jan Dittmer
2003-07-12 21:17     ` Dave Jones [this message]
2003-07-13 13:37       ` Jamie Lokier
2003-07-13 20:35         ` Rahul Karnik
  -- strict thread matches above, loose matches on Subject: below --
2003-07-13 10:17 Jaakko Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030712211721.GA10207@suse.de \
    --to=davej@codemonkey.org.uk \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.