All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Schaaf <bof@bof.de>
To: Poltorak Serguei <poltorak@df.ru>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: target MARK in filter table?
Date: Sun, 13 Jul 2003 16:19:44 +0200	[thread overview]
Message-ID: <20030713141944.GB1284@oknodo.bof.de> (raw)
In-Reply-To: <Pine.LNX.3.95.1030713163717.31849A-100000@cannabis.dataforce.net>

On Sun, Jul 13, 2003 at 04:43:13PM +0400, Poltorak Serguei wrote:
> 
> I tested MARK target with kernel without following line in linux/net/ipv4/netfilter/ipt_MARK.c
>         if (strcmp(tablename, "mangle") != 0) {
>                 printk(KERN_WARNING "MARK: can only be called from \"mangle\" table, not \"%s\"\n",
>                 return 0;
>         }
> 
> For now everything works including MARK target in chain INPUT of table filter.
> 
> If you do know a reason why this must not be done, please tell me. MARK is
> usefull even without advanced routing.

I do not disagree, the rerouting indecision was just the one possible reason
I could think of.

What do other developers think? What other reasons were there to keep the MARK
target from working in the filter table?

While we are on the topic of seemingly arbitrary "sanity" checks, why is
it that using the TCPMSS option throws a vague "invalid argument" error
when one forgets to also specify --syn? Can't that target just check for
tcp/syn dynamically, i.e. become a NOOP for non-syn packets, instead of
forcing me to specify --syn at rule insertion time?

best regards
  Patrick

  reply	other threads:[~2003-07-13 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-13  1:34 target MARK in filter table? Poltorak Serguei
2003-07-13  2:01 ` Poltorak Serguei
2003-07-13  7:02   ` Patrick Schaaf
2003-07-13 11:19     ` Poltorak Serguei
2003-07-13 12:43       ` Poltorak Serguei
2003-07-13 14:19         ` Patrick Schaaf [this message]
2003-07-14  8:05           ` Harald Welte
2003-07-15  4:26             ` Poltorak Serguei
2003-07-15  5:16               ` Patrick Schaaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030713141944.GB1284@oknodo.bof.de \
    --to=bof@bof.de \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=poltorak@df.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.