Re: [PATCH]: Fix ip_conntrack_core arguments to macros

[Harald Welte <laforge@netfilter.org>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

On Sat, Jul 12, 2003 at 12:40:47PM +0200, Patrick McHardy wrote:
> Hi Harald,
> this patch fixes some places in ip_conntrack where LIST_FIND and
> LIST_DELETE are passed functions with their arguments (like
> LIST_FIND(ip_conntrack_hash[hash_conntrack(...)], ...). The argument is
> expanded twice, this leads to two calls to hash_conntrack.

ouch, now this is interesting.  I need to look into that further.

Thanks for the patch, give me another day to investigate (and apply)
this and your other patches.

> Best regards,
> Patrick

> BTW: nice talk yesterday, i've seen the slides before but it still was
> alot more interesting to here it directly from you. Sorry i didn't showed
> up anymore, i had to get some sleep fast after getting up at 7 in the
> morning (and drinking too much beer) ;) Are you still at linuxtag ?

Yes, a real pity.  I was expecting to have some chat with you.
Unfortunately I needed to cut down my linuxtag visit to a single day
(just friday to give my presentation) due to a personal issue :(

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]