From: "David S. Miller" <davem@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: arjanv@redhat.com, torvalds@transmeta.com, greg@kroah.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove module reference counting.
Date: Fri, 25 Jul 2003 10:47:38 -0700 [thread overview]
Message-ID: <20030725104738.7ffbc118.davem@redhat.com> (raw)
In-Reply-To: <20030725173900.D7DE12C2A9@lists.samba.org>
On Fri, 25 Jul 2003 04:00:18 +1000
Rusty Russell <rusty@rustcorp.com.au> wrote:
> If module removal is to be a rare and unusual event, it
> doesn't seem so sensible to go to great lengths in the code to handle
> just that case. In fact, it's easier to leave the module memory in
> place, and not have the concept of parts of the kernel text (and some
> types of kernel data) vanishing.
>
> Polite feedback welcome,
I'm ok with this, with one possible enhancement.
How about we make ->cleanup() return a boolean, which if true
causes the caller to do the module_free()?
(Yes I know that doing this will require some more thought
in order to minimize how large a change it would need to
be to keep exiting modules working. It's a seperate discussion.)
next prev parent reply other threads:[~2003-07-25 17:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-24 18:00 [PATCH] Remove module reference counting Rusty Russell
2003-07-25 17:47 ` David S. Miller [this message]
2003-07-27 18:50 ` Rusty Russell
2003-07-25 17:54 ` Greg KH
2003-07-25 19:11 ` Greg KH
2003-07-25 19:26 ` Stephen Hemminger
2003-07-25 19:32 ` Greg KH
2003-07-25 22:26 ` Rusty Russell
2003-07-26 19:31 ` Linus Torvalds
2003-07-26 19:37 ` Arjan van de Ven
2003-07-27 5:38 ` Aschwin Marsman
2003-07-27 11:10 ` Alan Cox
2003-07-27 11:09 ` Alan Cox
2003-07-27 19:34 ` Rusty Russell
2003-07-27 21:47 ` Arjan van de Ven
2003-07-28 0:01 ` Alan Cox
2003-07-28 0:12 ` Bill Nottingham
2003-07-28 11:38 ` Alan Cox
2003-07-29 20:33 ` Rusty Russell
2003-07-30 1:55 ` Greg KH
2003-07-30 14:40 ` Alan Cox
2003-07-28 11:40 ` Alan Cox
2003-07-28 18:11 ` Gianni Tedesco
2003-07-28 19:03 ` Mike Fedyk
2003-08-01 2:39 ` Linus Torvalds
2003-07-25 23:24 ` Alan Cox
2003-07-27 18:48 ` Rusty Russell
2003-07-25 22:43 ` Gianni Tedesco
2003-07-25 23:37 ` Bernd Eckenfels
2003-07-26 20:18 ` Rusty Russell
2003-07-28 11:51 ` Rahul Karnik
2003-07-28 23:13 ` Rusty Russell
2003-07-29 2:39 ` Rahul Karnik
-- strict thread matches above, loose matches on Subject: below --
2003-07-29 2:10 Perez-Gonzalez, Inaky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030725104738.7ffbc118.davem@redhat.com \
--to=davem@redhat.com \
--cc=arjanv@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.