diff for duplicates of <2003077.85RPlhiJ1o@avalon> diff --git a/a/1.txt b/N1/1.txt index abd0677..7311d9c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -39,7 +39,7 @@ Do you foresee a use case for odd cropping top coordinates ? > > RWPF_PAD_SINK, > > sel->which); > > + -> > + if (format->code = MEDIA_BUS_FMT_AYUV8_1X32) { +> > + if (format->code == MEDIA_BUS_FMT_AYUV8_1X32) { > > + sel->r.left = (sel->r.left + 1) & ~1; > > + sel->r.top = (sel->r.top + 1) & ~1; > @@ -65,13 +65,14 @@ match the subdev width and height. However, it would be good to enforce the constraint better at the subdev level, by moving the above alignment code after these two lines. -> > if (rwpf->entity.type = VSP1_ENTITY_WPF) { +> > if (rwpf->entity.type == VSP1_ENTITY_WPF) { > > - sel->r.left = min_t(unsigned int, sel->r.left, 255); > > - sel->r.top = min_t(unsigned int, sel->r.top, 255); -> > + int maxcrop +> > + int maxcrop = + I would declare maxcrop as an unsigned int. -> > + format->code = MEDIA_BUS_FMT_AYUV8_1X32 ? 254 : 255; +> > + format->code == MEDIA_BUS_FMT_AYUV8_1X32 ? 254 : 255; > > I think you need an empty line here. > diff --git a/a/content_digest b/N1/content_digest index eb78330..1a89f73 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\05542105A.1010601@cogentembedded.com\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH/RFC] v4l: vsp1: Align crop rectangle to even boundary for YUV formats\0" - "Date\0Sun, 03 May 2015 22:13:12 +0000\0" + "Date\0Mon, 04 May 2015 01:13:12 +0300\0" "To\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Cc\0Yoshihiro Kaneko <ykaneko0929@gmail.com>" linux-media@vger.kernel.org @@ -54,7 +54,7 @@ "> > \tRWPF_PAD_SINK,\n" "> > \t\t\t\t\t sel->which);\n" "> > +\n" - "> > +\tif (format->code = MEDIA_BUS_FMT_AYUV8_1X32) {\n" + "> > +\tif (format->code == MEDIA_BUS_FMT_AYUV8_1X32) {\n" "> > +\t\tsel->r.left = (sel->r.left + 1) & ~1;\n" "> > +\t\tsel->r.top = (sel->r.top + 1) & ~1;\n" "> \n" @@ -80,13 +80,14 @@ "constraint better at the subdev level, by moving the above alignment code \n" "after these two lines.\n" "\n" - "> > \tif (rwpf->entity.type = VSP1_ENTITY_WPF) {\n" + "> > \tif (rwpf->entity.type == VSP1_ENTITY_WPF) {\n" "> > -\t\tsel->r.left = min_t(unsigned int, sel->r.left, 255);\n" "> > -\t\tsel->r.top = min_t(unsigned int, sel->r.top, 255);\n" - "> > +\t\tint maxcrop \n" + "> > +\t\tint maxcrop =\n" + "\n" "I would declare maxcrop as an unsigned int.\n" "\n" - "> > +\t\t\tformat->code = MEDIA_BUS_FMT_AYUV8_1X32 ? 254 : 255;\n" + "> > +\t\t\tformat->code == MEDIA_BUS_FMT_AYUV8_1X32 ? 254 : 255;\n" "> \n" "> I think you need an empty line here.\n" "> \n" @@ -107,4 +108,4 @@ "\n" Laurent Pinchart -d45d854b97dcd1581b63257c22de9b38e1d8851d7b8361fa3b4ec3614bb72b28 +cbd8eda2067cb815d17c6761e2ad378524341ce88c37c700338157427962620d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.