From: Matt Mackall <mpm@selenic.com>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/2] random: SMP locking
Date: Sat, 2 Aug 2003 09:43:10 -0500 [thread overview]
Message-ID: <20030802144310.GH22824@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.53.0308020832520.3473@montezuma.mastecende.com>
On Sat, Aug 02, 2003 at 08:35:22AM -0400, Zwane Mwaikambo wrote:
> On Sat, 2 Aug 2003, Andrew Morton wrote:
> > Cannot perform userspace access while holding a lock - a pagefault could
> > occur, perform IO, schedule away and the same CPU tries to take the same
> > lock via a different process.
>
> Perhaps might_sleep() in *_user, copy_* etc is in order?
Wouldn't have caught this case - this interface hasn't actually been
used/useful for many years as it only gives access to one of the
pools and has never been atomic either.
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-08-02 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-02 4:24 [PATCH] [1/2] random: SMP locking Oliver Xymoron
2003-08-02 11:00 ` Andrew Morton
2003-08-02 12:35 ` Zwane Mwaikambo
2003-08-02 14:43 ` Matt Mackall [this message]
2003-08-02 15:02 ` Zwane Mwaikambo
2003-08-02 18:39 ` Andrew Morton
2003-08-02 18:42 ` Matt Mackall
2003-08-02 14:32 ` Matt Mackall
2003-08-02 19:00 ` Andrew Morton
2003-08-02 19:33 ` Matt Mackall
2003-08-02 19:46 ` Andrew Morton
2003-08-02 20:14 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030802144310.GH22824@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.