Re: 2.6.0-test2-mm3 and mysql

[Andrew Morton <akpm@osdl.org>]

Shane Shrybman <shrybman@sympatico.ca> wrote:
>
> mysql doesn't start on this kernel.

That's because I'm an idiot.

--- 25/fs/mpage.c~awe-use-gfp_flags-braino	Sat Aug  2 18:03:01 2003
+++ 25-akpm/fs/mpage.c	Sat Aug  2 18:03:01 2003
@@ -568,7 +568,7 @@ confused:
 	 */
 	if (*ret == -ENOSPC)
 		set_bit(AS_ENOSPC, &mapping->flags);
-	else
+	else if (*ret)
 		set_bit(AS_EIO, &mapping->flags);
 out:
 	return bio;
@@ -673,7 +673,7 @@ mpage_writepages(struct address_space *m
 				ret = (*writepage)(page, wbc);
 				if (ret == -ENOSPC)
 					set_bit(AS_ENOSPC, &mapping->flags);
-				else
+				else if (ret)
 					set_bit(AS_EIO, &mapping->flags);
 			} else {
 				bio = mpage_writepage(bio, page, get_block,
diff -puN mm/vmscan.c~awe-use-gfp_flags-braino mm/vmscan.c
--- 25/mm/vmscan.c~awe-use-gfp_flags-braino	Sat Aug  2 18:03:01 2003
+++ 25-akpm/mm/vmscan.c	Sat Aug  2 18:03:01 2003
@@ -254,7 +254,7 @@ static void handle_write_error(struct ad
 	if (page->mapping == mapping) {
 		if (error == -ENOSPC)
 			set_bit(AS_ENOSPC, &mapping->flags);
-		else
+		else if (error)
 			set_bit(AS_EIO, &mapping->flags);
 	}
 	unlock_page(page);

_

> One last thing, I have started seeing mysql database corruption
> recently. I am not sure it is a kernel problem. And I don't know the
> exact steps to reproduce it, but I think I started seeing it with
> -test2-mm2. I haven't ever seen db corruption in the 8-12 months I have
> being playing with mysql/php.

hm, that's a worry.  No additional info available?