Re: [PATCH 2.6] ToPIC specific init for yenta_socket

[Daniel Ritz <daniel.ritz@gmx.ch>]

On Wed August 6 2003 20:44, Russell King wrote:
> On Wed, Aug 06, 2003 at 08:25:08PM +0200, Daniel Ritz wrote:
> > this patch adds override functions for the ToPIC family of controllers.
> > also adds the device id for ToPIC100 and (untested) support for zoom
> > video for ToPIC97/100.
> > 
> > tested with start/stop and suspend/resume.
> 
> We currently have some fairly serious IRQ problems with yenta at the
> moment.  I'm holding all patches until we get this problem resolved -
> it seems to be caused by several bad changes over the past couple of
> years accumulating throughout the 2.5 series.

yep, i saw the mails on lkml...

> 
> Therefore, I don't want to add any further changes into the mix just
> yet.

ok. the topic code is low-prio as these chips works mostly w/o the patch.
my craptop just fucks up in 1 of 30 boots or so.

> 
> Also, assigning to socket->socket.ops->init modifies the global
> yenta_socket_operations structure, which I'm far from happy about.

yes, i saw that too, but copy-pasted from the other overrides to fix up
in the next patch...i think ->init should always point to yenta_init,
the additional init function should be called from inside there, before
activating the interrupts...wanna have a patch?

-daniel


ps: in a few days, when i get my other laptop back, i have access to one of
those TI chips with all the nice problems (ie. under FreeBigStinkyDaemon the
machine dies under an interrupt storm when activating the socket) so i could
also test the irq routing and other fixes a bit.