From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] make sym2 scan devices again
Date: Fri, 8 Aug 2003 21:08:41 +0200 [thread overview]
Message-ID: <20030808190841.GC17983@lst.de> (raw)
In-Reply-To: <20030808190754.GB17983@lst.de>
On Fri, Aug 08, 2003 at 09:07:54PM +0200, Christoph Hellwig wrote:
> It needs a call to scsi_scan_host to find devices. Also remove the
> superflous scsi_set_device call - scsi_add_host does that for us.
Sorry, wrong patch - this was my whole sym2 pending queue.
diff -Nru a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c Fri Aug 8 11:11:33 2003
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c Fri Aug 8 11:11:33 2003
@@ -2015,17 +2015,17 @@
SYM_UNLOCK_HCB(np, flags);
- scsi_set_device(instance, &dev->pdev->dev);
-
/*
* Now let the generic SCSI driver
* look for the SCSI devices on the bus ..
*/
- scsi_add_host(instance, &dev->pdev->dev);
+ scsi_add_host(instance, &dev->pdev->dev); /* XXX: handle failure */
+ scsi_scan_host(instance);
return 0;
attach_failed:
- if (!instance) return -1;
+ if (!instance)
+ return -1;
printf_info("%s: giving up ...\n", sym_name(np));
if (np)
sym_free_resources(np);
prev parent reply other threads:[~2003-08-08 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-08 19:07 [PATCH] make sym2 scan devices again Christoph Hellwig
2003-08-08 19:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030808190841.GC17983@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.