From: Jasper Spaans <jasper@vs19.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix up fs/nfs/inode.c wrt flavo[u]r, try 2
Date: Sat, 9 Aug 2003 23:41:16 +0200 [thread overview]
Message-ID: <20030809214116.GA14409@spaans.vs19.net> (raw)
In-Reply-To: <20030809195607.GA8171@spaans.vs19.net>
Whoops, something went wrong here while exporting. Inline not wrapped etc bk
patch follows, and if someone has seen my brown paper bag, please tell me. I
think I lost it at friday's mud fight.
fs/nfs/inode.c | 18 +++++++++---------
include/linux/nfs4_mount.h | 4 ++--
include/linux/nfs_mount.h | 2 +-
3 files changed, 12 insertions(+), 12 deletions(-)
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1149 -> 1.1151
# include/linux/nfs_mount.h 1.4 -> 1.5
# include/linux/nfs4_mount.h 1.1 -> 1.2
# fs/nfs/inode.c 1.84 -> 1.86
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/08/09 jasper@vs19.net 1.1150
# Change spelling of flavour to flavor in fs/nfs/inode.c and the headers this file includes
#
# This prevents any confusion that might arise because both spellings are used in the same source file.
# --------------------------------------------
# 03/08/09 jasper@vs19.net 1.1151
# fs/nfs/inode.c cleanup: correct once more
# --------------------------------------------
#
diff -Nru a/fs/nfs/inode.c b/fs/nfs/inode.c
--- a/fs/nfs/inode.c Sat Aug 9 23:34:27 2003
+++ b/fs/nfs/inode.c Sat Aug 9 23:34:27 2003
@@ -478,7 +478,7 @@
}
/* Fill in pseudoflavor for mount version < 5 */
- if (!(data->flags & NFS_MOUNT_SECFLAVOUR))
+ if (!(data->flags & NFS_MOUNT_SECFLAVOR))
data->pseudoflavor = RPC_AUTH_UNIX;
authflavor = data->pseudoflavor; /* save for sb_init() */
/* XXX maybe we want to add a server->pseudoflavor field */
@@ -1296,7 +1296,7 @@
memcpy(root->data, data->old_root.data, NFS2_FHSIZE);
}
if (data->version < 5)
- data->flags &= ~NFS_MOUNT_SECFLAVOUR;
+ data->flags &= ~NFS_MOUNT_SECFLAVOR;
}
if (root->size > sizeof(root->data)) {
@@ -1354,7 +1354,7 @@
struct rpc_xprt *xprt = NULL;
struct rpc_clnt *clnt = NULL;
struct rpc_timeout timeparms;
- rpc_authflavor_t authflavour;
+ rpc_authflavor_t authflavor;
int proto, err = -EIO;
sb->s_blocksize_bits = 0;
@@ -1407,17 +1407,17 @@
goto out_fail;
}
- authflavour = RPC_AUTH_UNIX;
- if (data->auth_flavourlen != 0) {
- if (data->auth_flavourlen > 1)
+ authflavor = RPC_AUTH_UNIX;
+ if (data->auth_flavorlen != 0) {
+ if (data->auth_flavorlen > 1)
printk(KERN_INFO "NFS: cannot yet deal with multiple auth flavours.\n");
- if (copy_from_user(&authflavour, data->auth_flavours, sizeof(authflavour))) {
+ if (copy_from_user(&authflavor, data->auth_flavors, sizeof(authflavor))) {
err = -EFAULT;
goto out_fail;
}
}
clnt = rpc_create_client(xprt, server->hostname, &nfs_program,
- server->rpc_ops->version, authflavour);
+ server->rpc_ops->version, authflavor);
if (clnt == NULL) {
printk(KERN_WARNING "NFS: cannot create RPC client.\n");
xprt_destroy(xprt);
@@ -1441,7 +1441,7 @@
if ((server->idmap = nfs_idmap_new(server)) == NULL)
printk(KERN_WARNING "NFS: couldn't start IDmap\n");
- err = nfs_sb_init(sb, authflavour);
+ err = nfs_sb_init(sb, authflavor);
if (err == 0)
return 0;
rpciod_down();
diff -Nru a/include/linux/nfs4_mount.h b/include/linux/nfs4_mount.h
--- a/include/linux/nfs4_mount.h Sat Aug 9 23:34:27 2003
+++ b/include/linux/nfs4_mount.h Sat Aug 9 23:34:27 2003
@@ -51,8 +51,8 @@
int proto; /* 1 */
/* Pseudo-flavours to use for authentication. See RFC2623 */
- int auth_flavourlen; /* 1 */
- int *auth_flavours; /* 1 */
+ int auth_flavorlen; /* 1 */
+ int *auth_flavors; /* 1 */
};
/* bits in the flags field */
diff -Nru a/include/linux/nfs_mount.h b/include/linux/nfs_mount.h
--- a/include/linux/nfs_mount.h Sat Aug 9 23:34:27 2003
+++ b/include/linux/nfs_mount.h Sat Aug 9 23:34:27 2003
@@ -57,7 +57,7 @@
#define NFS_MOUNT_NONLM 0x0200 /* 3 */
#define NFS_MOUNT_BROKEN_SUID 0x0400 /* 4 */
#define NFS_MOUNT_STRICTLOCK 0x1000 /* reserved for NFSv4 */
-#define NFS_MOUNT_SECFLAVOUR 0x2000 /* 5 */
+#define NFS_MOUNT_SECFLAVOR 0x2000 /* 5 */
#define NFS_MOUNT_FLAGMASK 0xFFFF
#endif
VrGr,
--
Jasper Spaans http://jsp.vs19.net/contact/
next prev parent reply other threads:[~2003-08-09 21:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-07 18:00 [PATCH] Change all occurrences of 'flavour' to 'flavor' Jasper Spaans
2003-08-07 22:37 ` Alan Cox
2003-08-08 0:04 ` Martin J. Bligh
2003-08-08 16:54 ` Steven Cole
2003-08-08 5:46 ` [PATCH] Change all occurrences of 'flavour' to 'flavor', torvalds@osdl.org Jasper Spaans
[not found] ` <200308080153.22495.jcwren@jcwren.com>
2003-08-08 5:58 ` [ot] Re: [PATCH] Change all occurrences of 'flavour' to 'flavor' Jasper Spaans
2003-08-08 7:13 ` Jens Axboe
2003-08-08 1:42 ` Zwane Mwaikambo
2003-08-08 6:52 ` Jasper Spaans
2003-08-08 6:57 ` Zwane Mwaikambo
2003-08-08 7:15 ` Jens Axboe
2003-08-08 11:04 ` [OT] " Adrian Bunk
2003-08-08 16:58 ` Svein Ove Aas
2003-08-08 21:51 ` Ian Hastie
2003-08-08 7:33 ` Jasper Spaans
2003-08-08 7:40 ` Jens Axboe
2003-08-08 8:00 ` Jasper Spaans
2003-08-08 8:54 ` Jens Axboe
2003-08-08 7:45 ` Zwane Mwaikambo
2003-08-08 7:07 ` Alexander Winston
2003-08-08 7:31 ` Jasper Spaans
2003-08-08 7:11 ` Tomas Szepe
2003-08-08 15:18 ` Timothy Miller
2003-08-08 15:34 ` Richard B. Johnson
2003-08-08 15:48 ` Trond Myklebust
2003-08-08 16:42 ` Gene Heskett
2003-08-08 17:03 ` Jasper Spaans
2003-08-08 17:34 ` Alan Cox
2003-08-08 18:02 ` Gene Heskett
2003-08-08 15:50 ` Jasper Spaans
2003-08-08 16:00 ` Richard B. Johnson
2003-08-08 17:18 ` Linus Torvalds
2003-08-08 17:33 ` Jasper Spaans
2003-08-09 0:24 ` Trond Myklebust
2003-08-09 0:41 ` Linus Torvalds
2003-08-09 0:45 ` Jasper Spaans
2003-08-09 19:56 ` [PATCH] Fix up fs/nfs/inode.c wrt flavo[u]r Jasper Spaans
2003-08-09 19:51 ` Zwane Mwaikambo
2003-08-09 21:41 ` Jasper Spaans [this message]
2003-08-09 1:04 ` [PATCH] Change all occurrences of 'flavour' to 'flavor' Trond Myklebust
2003-08-09 1:17 ` Ian Hastie
2003-08-09 7:23 ` jw schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030809214116.GA14409@spaans.vs19.net \
--to=jasper@vs19.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.