From: Chip Salzenberg <chip@pobox.com>
To: Willy Tarreau <willy@w.ods.org>
Cc: Albert Cahalan <albert@users.sourceforge.net>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>,
davem@redhat.com, jamie@shareable.org
Subject: Re: [PATCH] 2.4.22pre10: {,un}likely_p() macros for pointers
Date: Sun, 10 Aug 2003 21:23:37 -0400 [thread overview]
Message-ID: <20030811012337.GI24349@perlsupport.com> (raw)
In-Reply-To: <20030810072945.GA14038@alpha.home.local>
According to Willy Tarreau:
> likely => __builtin_expect(!(x), 0)
> unlikely => __builtin_expect((x), 0)
Well, I'm not sure about the polarity, but that unlikely() macro isn't
good -- it the same old problem that first prompted my message, namely
that it's nonportable when (x) has a pointer type.
--
Chip Salzenberg - a.k.a. - <chip@pobox.com>
"I wanted to play hopscotch with the impenetrable mystery of existence,
but he stepped in a wormhole and had to go in early." // MST3K
next prev parent reply other threads:[~2003-08-11 1:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-10 4:03 [PATCH] 2.4.22pre10: {,un}likely_p() macros for pointers Albert Cahalan
2003-08-10 7:29 ` Willy Tarreau
2003-08-10 8:02 ` Willy Tarreau
2003-08-11 1:23 ` Chip Salzenberg [this message]
2003-08-11 2:09 ` Jamie Lokier
2003-08-11 2:39 ` Chip Salzenberg
2003-08-11 4:02 ` Albert Cahalan
2003-08-11 4:30 ` Jamie Lokier
2003-08-11 5:30 ` Willy Tarreau
2003-08-11 5:42 ` Jamie Lokier
2003-08-11 13:09 ` Albert Cahalan
2003-08-11 18:55 ` Andrew Morton
2003-08-11 23:13 ` Albert Cahalan
2003-08-13 19:42 ` Jamie Lokier
2003-08-11 4:55 ` Jamie Lokier
2003-08-11 5:26 ` Willy Tarreau
2003-08-11 5:38 ` Jamie Lokier
-- strict thread matches above, loose matches on Subject: below --
2003-08-05 12:44 Albert Cahalan
2003-08-09 0:21 ` Jamie Lokier
2003-08-09 8:13 ` Willy Tarreau
2003-08-09 8:51 ` David S. Miller
2003-08-09 9:36 ` Jamie Lokier
2003-08-09 10:10 ` Herbert Xu
2003-08-09 10:42 ` Alan Cox
2003-08-09 16:23 ` Jamie Lokier
2003-08-04 17:06 Chip Salzenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030811012337.GI24349@perlsupport.com \
--to=chip@pobox.com \
--cc=albert@users.sourceforge.net \
--cc=davem@redhat.com \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.