From: Greg KH <greg@kroah.com>
To: Jeff Woods <kazrak+kernel@cesmail.net>
Cc: Andries Brouwer <aebr@win.tue.nl>,
linux-scsi@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] Re: [PATCH] oops in sd_shutdown
Date: Tue, 12 Aug 2003 14:36:46 -0700 [thread overview]
Message-ID: <20030812213646.GB2158@kroah.com> (raw)
In-Reply-To: <5.2.1.1.0.20030811233014.02900008@no.incoming.mail>
On Mon, Aug 11, 2003 at 11:35:26PM -0700, Jeff Woods wrote:
> At +0200 04:49 AM 8/12/2003, Andries Brouwer wrote:
> >On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
> >
> >>Looking only at the above code snippet, I'd suggest something more like:
> >
> >>+ if (!sdp ||
> >
> >This is not meaningful.
>
> How is it not meaningful? The next action in the expression is to
> dereference the pointer and if it has a NULL value then I expect the
> dereference to fail. [But I am a complete newbie with respect to Linux
> kernel and driver code so perhaps my understanding is in error. If so,
> please enlighten me.]
sdp can not be NULL in this case. That is why it is not meaningful to
try to check for it.
thanks,
greg k-h
next prev parent reply other threads:[~2003-08-12 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.53.0308111426570.16008@thevillage.soulcatcher>
2003-08-11 22:28 ` [PATCH] oops in sd_shutdown Andries Brouwer
2003-08-11 22:28 ` Andries Brouwer
2003-08-12 1:13 ` Jeff Woods
2003-08-12 2:49 ` Andries Brouwer
2003-08-12 6:35 ` Jeff Woods
2003-08-12 21:36 ` Greg KH [this message]
2003-08-12 6:53 ` Christoph Hellwig
2003-08-12 8:51 ` Andries Brouwer
2003-08-12 21:35 ` [linux-usb-devel] " Greg KH
2003-08-13 0:24 ` Mike Anderson
2003-08-13 10:46 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030812213646.GB2158@kroah.com \
--to=greg@kroah.com \
--cc=aebr@win.tue.nl \
--cc=kazrak+kernel@cesmail.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.