From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Braam Subject: Re: [PATCH] remove TCGETS Date: Tue, 12 Aug 2003 19:42:05 -0600 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030813014205.GA2267@localhost.localdomain> References: <20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk> <20030812155956.C3708@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from moraine.clusterfs.com ([216.138.243.178]:3737 "EHLO moraine.clusterfs.com") by vger.kernel.org with ESMTP id S271089AbTHMBmZ (ORCPT ); Tue, 12 Aug 2003 21:42:25 -0400 To: Matthew Wilcox , intermezzo-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Content-Disposition: inline In-Reply-To: <20030812155956.C3708@schatzie.adilger.int> List-Id: linux-fsdevel.vger.kernel.org Also we don't use Perl anymore - ditch it. Thanks Matthew. - Peter - On Tue, Aug 12, 2003 at 03:59:56PM -0600, Andreas Dilger wrote: > On Aug 12, 2003 22:48 +0100, Matthew Wilcox wrote: > > I see no reason to handle TCGETS in presto_ioctl, and even if you do get > > it somehow, the action is the same as the default. This happens to break > > on PA-RISC and not on i386 due to i386 using an old-style definition of > > TCGETS and PA-RISC using one which invovles sizeof(). > > > > diff -urpNX dontdiff linus-2.6/fs/intermezzo/dir.c parisc-2.6/fs/intermezzo/dir.c > > --- linus-2.6/fs/intermezzo/dir.c Tue Aug 12 13:11:17 2003 > > +++ parisc-2.6/fs/intermezzo/dir.c Tue Aug 12 13:29:43 2003 > > @@ -1304,10 +1304,6 @@ int presto_ioctl(struct inode *inode, st > > return rc; > > } > > > > - case TCGETS: > > - EXIT; > > - return -EINVAL; > > - > > default: > > EXIT; > > return -EINVAL; > > I can tell you why this was originally in there - because the "default" case > used to print out an error message for unhandled ioctls. Perl used to call > TCGETS all the time on files in lustre, so we put in the no-op case to shut > up the error messages. Now that the error messages are gone from the default > case there is no need to have this there anymore, so removing it is fine. > > Cheers, Andreas > -- > Andreas Dilger > http://sourceforge.net/projects/ext2resize/ > http://www-mddsp.enel.ucalgary.ca/People/adilger/ > > > > ------------------------------------------------------- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 > _______________________________________________ > intermezzo-devel mailing list > intermezzo-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/intermezzo-devel - Peter -