From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Braam Subject: Re: [PATCH] remove TCGETS Date: Wed, 13 Aug 2003 19:28:18 -0600 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030814012818.GD1918@localhost.localdomain> References: <20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk> <20030812155956.C3708@schatzie.adilger.int> <1060776724.2226.49.camel@passion.cambridge.redhat.com> <20030813093521.F3708@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from moraine.clusterfs.com ([216.138.243.178]:20609 "EHLO moraine.clusterfs.com") by vger.kernel.org with ESMTP id S272131AbTHNB2V (ORCPT ); Wed, 13 Aug 2003 21:28:21 -0400 To: David Woodhouse , Matthew Wilcox , intermezzo-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Content-Disposition: inline In-Reply-To: <20030813093521.F3708@schatzie.adilger.int> List-Id: linux-fsdevel.vger.kernel.org In fact some part of POSIX says that ioctls should return EINVAL that's why I made that choice. Anyway, the issue is moot. - Peter - On Wed, Aug 13, 2003 at 09:35:21AM -0600, Andreas Dilger wrote: > On Aug 13, 2003 13:12 +0100, David Woodhouse wrote: > > On Tue, 2003-08-12 at 22:59, Andreas Dilger wrote: > > > On Aug 12, 2003 22:48 +0100, Matthew Wilcox wrote: > > > > I see no reason to handle TCGETS in presto_ioctl, and even if you do get > > > > it somehow, the action is the same as the default. This happens to break > > > > on PA-RISC and not on i386 due to i386 using an old-style definition of > > > > TCGETS and PA-RISC using one which invovles sizeof(). > > > > > > > > diff -urpNX dontdiff linus-2.6/fs/intermezzo/dir.c parisc-2.6/fs/intermezzo/dir.c > > > > --- linus-2.6/fs/intermezzo/dir.c Tue Aug 12 13:11:17 2003 > > > > +++ parisc-2.6/fs/intermezzo/dir.c Tue Aug 12 13:29:43 2003 > > > > @@ -1304,10 +1304,6 @@ int presto_ioctl(struct inode *inode, st > > > > return rc; > > > > } > > > > > > > > - case TCGETS: > > > > - EXIT; > > > > - return -EINVAL; > > > > - > > > > default: > > > > EXIT; > > > > return -EINVAL; > > > > > > I can tell you why this was originally in there - because the "default" case > > > used to print out an error message for unhandled ioctls. Perl used to call > > > TCGETS all the time on files in lustre, so we put in the no-op case to shut > > > up the error messages. Now that the error messages are gone from the default > > > case there is no need to have this there anymore, so removing it is fine. > > > > Why was it returning -EINVAL instead of -ENOTTY? > > An oversight. Returning -ENOTTY is what I would do today. > > Cheers, Andreas > -- > Andreas Dilger > http://sourceforge.net/projects/ext2resize/ > http://www-mddsp.enel.ucalgary.ca/People/adilger/ > > > > ------------------------------------------------------- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 > _______________________________________________ > intermezzo-devel mailing list > intermezzo-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/intermezzo-devel - Peter -