From: Christoph Hellwig <hch@infradead.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Pavel Machek <pavel@suse.cz>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] call drv->shutdown at rmmod
Date: Thu, 14 Aug 2003 08:54:43 +0100 [thread overview]
Message-ID: <20030814085442.A21232@infradead.org> (raw)
In-Reply-To: <m1he4kzpiy.fsf@frodo.biederman.org>; from ebiederm@xmission.com on Thu, Aug 14, 2003 at 01:06:45AM -0600
On Thu, Aug 14, 2003 at 01:06:45AM -0600, Eric W. Biederman wrote:
>
> At the kexec BOF at OSDL there was some discussion on calling the
> device shutdown method at module remove time, in addition to calling
> it during reboot. The driver was the observation that the primary
> source of problems in booting linux from linux are drivers with bad
> or missing drv->shutdown() routines. The hope is this will increase
> the testing so people can get it right and kexec can become more
> useful. In addition to making normal reboots more reliable.
>
> The following patch is an implementation of that idea it calls drv->shutdown()
> before calling drv->remove(). If drv->shutdown() is implemented.
Sounds really confusing. And having shutdown maybe called before remove
but not always sounds like a design mistake.
Why do we have shutdown at all? Can't we just call ->remove on shutdown
so the device always get's into proper unitialized state on shutdown, too?
next prev parent reply other threads:[~2003-08-14 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-14 7:06 [PATCH] call drv->shutdown at rmmod Eric W. Biederman
2003-08-14 7:54 ` Christoph Hellwig [this message]
2003-08-14 8:06 ` Russell King
2003-08-14 15:50 ` Eric W. Biederman
2003-08-14 16:07 ` Russell King
2003-08-14 17:26 ` Eric W. Biederman
2003-08-17 22:26 ` [PATCH] don't call device_shutdown on halt Eric W. Biederman
2003-08-14 16:40 ` [PATCH] call drv->shutdown at rmmod Russell King
2003-08-14 16:02 ` Patrick Mochel
2003-08-14 16:26 ` Eric W. Biederman
2003-08-14 16:41 ` Patrick Mochel
2003-08-14 17:41 ` Eric W. Biederman
2003-08-15 8:51 ` Benjamin Herrenschmidt
2003-08-15 15:28 ` Eric W. Biederman
2003-08-15 16:01 ` Benjamin Herrenschmidt
2003-08-15 16:30 ` Patrick Mochel
2003-08-14 16:47 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030814085442.A21232@infradead.org \
--to=hch@infradead.org \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.