All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Lenehan <lenehan@twibble.org>
To: linux-scsi@vger.kernel.org
Cc: James Bottomley <James.Bottomley@steeleye.com>, dc395x@twibble.org
Subject: [PATCH] dc395x - fix compile
Date: Sun, 17 Aug 2003 13:51:59 +1000	[thread overview]
Message-ID: <20030817035159.GA13666@twibble.org> (raw)

Hi,

this patch is good and needs to be applied to get the dc395x driver
in the current tree (2.6.0-test3-bk3) to build (it's not yet included
in the scsi-misc tree).

Thanks.

----- Forwarded message from Christoph Hellwig <hch@lst.de> -----
From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] fix dc395x compile
Date: Fri, 8 Aug 2003 21:07:06 +0200
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>

The recent update made it check the scsi_remove_host retval which
is void now.

diff -Nru a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
--- a/drivers/scsi/dc395x.c	Fri Aug  8 11:11:11 2003
+++ b/drivers/scsi/dc395x.c	Fri Aug  8 11:11:11 2003
@@ -5862,14 +5862,7 @@
 	struct Scsi_Host *host = pci_get_drvdata(dev);
 
 	dprintkdbg(DBG_0, "Removing instance\n");
-	if (!host) {
-		dprintkl(KERN_ERR, "no host allocated\n");
-		return;
-	}
-	if (scsi_remove_host(host)) {
-		dprintkl(KERN_ERR, "scsi_remove_host failed\n");
-		return;
-	}
+	scsi_remove_host(host);
 	host_release(host);
 	scsi_host_put(host);
 	pci_set_drvdata(dev, NULL);

----- End forwarded message -----

-- 
 Jamie Lenehan <lenehan@twibble.org>

                 reply	other threads:[~2003-08-17  3:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030817035159.GA13666@twibble.org \
    --to=lenehan@twibble.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=dc395x@twibble.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.