All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andries.Brouwer@cwi.nl, Dominik.Strasser@t-online.de,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	torvalds@transmeta.com
Subject: Re: [PATCH] Re: [PATCH] scsi.h uses "u8" which isn't defined.
Date: Mon, 18 Aug 2003 11:32:39 -0400	[thread overview]
Message-ID: <20030818153239.GC24693@gtf.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0308180820470.1672-100000@home.osdl.org>

On Mon, Aug 18, 2003 at 08:21:45AM -0700, Linus Torvalds wrote:
> 
> On Mon, 18 Aug 2003 Andries.Brouwer@cwi.nl wrote:
> > 
> > I see that Linus already applied this, but I am quite unhappy with
> > these changes. Entirely needlessly user space software is broken.
> 
> If it's supposed to be exported to user space, it _still_ must not use 
> "u_char", since that isn't namespace-clean.
> 
> If it needs exporting, it must use "__u8".

Maybe I am biased, but I actually prefer to use the C99 size-specific
types, when code will be used outside the kernel tree...  even if that
userland code is entirely Linux-kernel-specific.  I try to avoid "__u<size>"
since it's typically a gcc-specific type.

C99 gave us the tools, we should use them :)

	Jeff



  reply	other threads:[~2003-08-18 15:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-18 12:19 [PATCH] Re: [PATCH] scsi.h uses "u8" which isn't defined Andries.Brouwer
2003-08-18 12:24 ` Christoph Hellwig
2003-08-18 18:08   ` Sam Ravnborg
2003-08-18 18:14     ` Jeff Garzik
2003-08-18 15:21 ` Linus Torvalds
2003-08-18 15:32   ` Jeff Garzik [this message]
2003-08-18 16:13 ` Patrick Mansfield
  -- strict thread matches above, loose matches on Subject: below --
2003-08-18 12:36 Andries.Brouwer
     [not found] <lRjc.6o4.3@gated-at.bofh.it>
     [not found] ` <lRjg.6o4.15@gated-at.bofh.it>
     [not found]   ` <lWLS.39x.5@gated-at.bofh.it>
     [not found]     ` <lWLZ.39x.29@gated-at.bofh.it>
2003-08-18 18:54       ` Ihar 'Philips' Filipau
2003-08-18 19:04         ` Jeff Garzik
2003-08-19 12:32           ` Rob Landley
2003-08-19 17:26             ` Jeff Garzik
2003-08-20  1:42               ` Erik Andersen
2003-08-20 23:48             ` Jamie Lokier
2003-08-21  0:02               ` Jeff Garzik
2003-08-22  0:32                 ` Rob Landley
2003-08-22  0:50                   ` Chris Friesen
2003-08-22  1:58                     ` Rob Landley
2003-08-22  0:54                   ` Jeff Garzik
2003-08-18 20:40         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030818153239.GC24693@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=Dominik.Strasser@t-online.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.