From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Jes Sorensen <jes@wildopensource.com>
Subject: Re: Qla1280 update to 3.23.24
Date: Mon, 18 Aug 2003 12:18:00 -0400 [thread overview]
Message-ID: <20030818161800.GE24693@gtf.org> (raw)
In-Reply-To: <200308181606.h7IG6utZ021778@hera.kernel.org>
On Thu, Aug 14, 2003 at 11:16:27PM +0000, Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/scsi/qla1280.h b/drivers/scsi/qla1280.h
> --- a/drivers/scsi/qla1280.h Mon Aug 18 09:07:03 2003
> +++ b/drivers/scsi/qla1280.h Mon Aug 18 09:07:03 2003
> @@ -1111,7 +1111,11 @@
> /*
> * Linux - SCSI Driver Interface Function Prototypes.
> */
> +#if LINUX_VERSION_CODE < 0x020600
> int qla1280_proc_info(char *, char **, off_t, int, int, int);
> +#else
> +int qla1280_proc_info(struct Scsi_Host *, char *, char **, off_t, int, int);
> +#endif
Since we have people _constantly_ screwing this up (but of course, never
you, Jes :)), please use the KERNEL_VERSION() macro instead of
open-coding the kernel version you are testing. It makes these tests
not only harder to screw up, but easier to read, too.
Jeff
next parent reply other threads:[~2003-08-18 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200308181606.h7IG6utZ021778@hera.kernel.org>
2003-08-18 16:18 ` Jeff Garzik [this message]
2003-08-19 9:26 ` Qla1280 update to 3.23.24 Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030818161800.GE24693@gtf.org \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=jes@wildopensource.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.